Floating panel and UI enhancement #15
Conversation
|
@esreli can you please review. |
There was a problem hiding this comment.
This is coming along quite nicely! I just have a few notes on the UI here,
Floating Panel UI
Dismiss action kills app
When I swipe the floating panel downward with force, it dismisses the floating panel all together. Abruptly after that happens, the app crashes. Do you know what's going on here?
Floating panel subtitle alignment
Using the app as-is, i'm not able to test whether the subtitle alignment is fixed. Can you confirm the subtitle left-alignment matches that of the title label?
Pop-up View & Edit
Outlined input fields
It's hard to tell when the pop-up view has entered edit mode. I'm thinking we should use a UI component that strongly indicates edit mode has begun. Material Design contains an outlined text field that might work really well for us here by changing the UI of every input field. What do you think?
Full width coded value domain fields
Attribute fields for coded value domains use a drop down icon for activating a picker. The right-alignment of the dropdown icon seems to float somewhere in the middle of the cell. Is it possible to align the dropdown button to the right side of the cell and extend the tappable area to the cell's full width?
There was a problem hiding this comment.
Hey Puneet, the work continues to look pretty good. I think we're almost there. I've found a few bugs and identified some areas where the design can be modified to match behavior found in the .Net and iOS apps.
Thanks!
Bug: Overlapping Attribute Fields
There appears to be a bug where two attribute fields are overlayed on top of one another. Steps to repro,
- Identify a Tree feature
- Expand Tree feature
- Start editing Tree feature
Note, I could not reproduce this case frequently, it only happened sometimes. It feels like a race condition bug but I can't be entirely sure...
In this screenshot, the 'Address' and 'Condition' fields appear to be stacked on one another.
Emulator Pixel 4 API 30
Bug: UI is not paused while editing activity indicator is present
When the activity indicator is present (after tapping saving edits) the UI beneath the activity indicator is still accessible. A user is still able to edit field values or drag the attributes list. Is there an Android mechanism for disabling UI when a long-running operation is being performed?
Design: Edit controls tab bar position
It appears the Edit controls tab is positioned at the top of the view. Is this intentional? Instead, can we match the behavior found in the iOS and .Net apps where the tool bar is always present and fixed to the bottom of the view?
See this PR comment for screenshots.
Design: tab bar background color
Can you match the background color to the light gray found in the .Net app?
Color.rgb(248, 248, 248)Design: Edit controls icon size
Would you change the size of the edit controls icon size? We should use the 24pt sized icon and render the icon in the app at the same size, 24pts.
Design: Start edit icon image
The calcite icon that the team has chosen to iconify the Start editing button is the pencil icon. I see why you chose the current icon (and I like that icon!) but I think the Android app should match the .Net app and the iOS app.
If you feel strongly about using the edit attributes icon then I encourage you to raise this design change with the rest of the team.
The position that I hold equally strong to the icon selection is that they all match.
There was a problem hiding this comment.
Thanks for your work here! There are still some kinks to work out before this work is squared away.
Non-VPN Connected Build
When I went to build and I was not connected to the VPN, I was provided this error. Do you know what this is? Will this affect our external customers?
Unknown host 'olympus.esri.com'. You may need to adjust the proxy settings in Gradle.
Minimized Floating Panel Position
When the floating panel is minimized, the toolbar obfuscates the floating panel. The floating panel should contain the toolbar and the header's visibility should supersede the toolbar's visibility.
Toolbar obfuscating last field
The last attribute is partially obfuscated by the toolbar. This is true for both when the view is in view mode or edit mode. As such, I am unable to read the contents of the final attribute nor edit it.
I am using that endpoint to access the internal toolkit build which has the popup toolkit component. I will take out this end point once the toolkit release is public.
I have pushed a fix for both those issues. Please have another look. |
There was a problem hiding this comment.
This all looks good to me!
As for the release of Data Collection 0.2, it would still be my preference that the full pop-up view is displayed right away rather than supporting a list of length 1 result. Is it possible to stash the results list related work on a separate branch and remove the list view for the 0.2 release?
For Issue: https://github.com/ArcGIS/open-source-apps/issues/443