Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/account tile updates #487

Merged
merged 4 commits into from
Jul 19, 2021
Merged

Feat/account tile updates #487

merged 4 commits into from
Jul 19, 2021

Conversation

joeyHarig
Copy link
Collaborator

Description

  • Updated width of AccountTile icons container so that it won't collapse when there's a long username
  • Changed prop hideIcons to hideAuthentication and also determine whether to hide ellipse based on if the tile is clickable
  • Updated docs to reflect changes

Related Issue

#486

Motivation and Context

  • Needed to add back auth icon and tooltip to ArcGIS Assistant copy items account select workflow
  • Icon wrapper was being squished by long usernames

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@joeyHarig joeyHarig requested review from codylawson and LeviRemi July 19, 2021 16:54
@joeyHarig joeyHarig self-assigned this Jul 19, 2021
Copy link
Collaborator

@LeviRemi LeviRemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled it into Assistant to test and it looks great! Thanks Joey.
Screen Shot 2021-07-19 at 10 13 10 AM

@joeyHarig
Copy link
Collaborator Author

@LeviRemi Oh let me push one more change to justify the auth icon to the end when no other icon is present.

@joeyHarig
Copy link
Collaborator Author

@LeviRemi Alright should be could to go. Could you share one more screenshot just to verify?

@LeviRemi
Copy link
Collaborator

Verified 👍
Screen Shot 2021-07-19 at 10 37 24 AM

@joeyHarig
Copy link
Collaborator Author

@LeviRemi Perfect thank you

@joeyHarig joeyHarig merged commit 9e29759 into develop Jul 19, 2021
@joeyHarig joeyHarig deleted the feat/account-tile-updates branch July 19, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants