Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(popover): add token theming tests #9460

Merged
merged 2 commits into from
May 30, 2024
Merged

test(popover): add token theming tests #9460

merged 2 commits into from
May 30, 2024

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented May 30, 2024 •
edited
Loading

Related Issue: #7180

Summary

Add token theming tests for popover component.

@anveshmekala anveshmekala requested a review from a team as a code owner May 30, 2024 04:13
alisonailea
alisonailea approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Small change requested to reference the FloatingCSS.animation class instead of statically typing it. for background, border, and shadow

packages/calcite-components/src/components/popover/popover.e2e.ts Show resolved Hide resolved
@anveshmekala anveshmekala merged commit 1169e80 into epic/7180-component-tokens May 30, 2024
4 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/7180-popover-token-theming-tests branch May 30, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @alisonailea