fix(alert): update alert queue when an alert is removed from the DOM #7189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
commented
Jun 16, 2023
driskull
added
the
pr ready for visual snapshots
jcfranco
approved these changes
Jun 20, 2023
There was a problem hiding this comment.
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🎤🎤🎤🎤🕺🎤🎤🎤🎤🕺🎤🕺🕺🕺🎤🕺
🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🕺🎤🕺🎤🕺🕺
🕺🎤🎤🎤🕺🕺🎤🎤🎤🎤🕺🎤🎤🎤🕺🕺🕺🕺🎤🕺🕺🕺
🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺
🕺🎤🎤🎤🎤🕺🎤🕺🕺🎤🕺🎤🎤🎤🎤🕺🕺🕺🎤🕺🕺🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🎤🕺🕺🕺🎤🕺🎤🎤🎤🎤🕺
🕺🎤🕺🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🕺🕺🕺
🕺🎤🎤🎤🕺🕺🕺🕺🎤🕺🕺🕺🎤🎤🎤🕺🕺
🕺🎤🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🕺🕺🎤🕺🕺🕺🎤🎤🎤🎤🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🎤🕺🕺🕺🎤🕺🎤🎤🎤🎤🕺
🕺🎤🕺🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🕺🕺🕺
🕺🎤🎤🎤🕺🕺🕺🕺🎤🕺🕺🕺🎤🎤🎤🕺🕺
🕺🎤🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🕺🕺🎤🕺🕺🕺🎤🎤🎤🎤🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🎤🕺🕺🕺🎤🕺🎤🎤🎤🎤🕺
🕺🎤🕺🕺🎤🕺🕺🎤🕺🎤🕺🕺🎤🕺🕺🕺🕺
🕺🎤🎤🎤🕺🕺🕺🕺🎤🕺🕺🕺🎤🎤🎤🕺🕺
🕺🎤🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺🎤🕺🕺🕺🕺
🕺🎤🎤🎤🎤🕺🕺🕺🎤🕺🕺🕺🎤🎤🎤🎤🕺
🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺🕺
|
|
||
| window.dispatchEvent( | ||
| new CustomEvent<Sync>("calciteInternalAlertSync", { | ||
| cancelable: false, |
There was a problem hiding this comment.
Custom events are not cancelable by default, so this can be dropped.
driskull
added
pr ready for visual snapshots
Merged
benelan
added a commit
that referenced
this pull request
Jun 27, 2023
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 1.4.3</summary> ## [1.4.3](https://github.com/Esri/calcite-components/compare/@esri/[email protected]...@esri/[email protected]) (2023-06-26) ### Bug Fixes * **accordion-item:** support items working across shadowDOM ([#7035](#7035)) ([6378e35](6378e35)), closes [#6167](#6167) * **alert:** Sets autoCloseDuration to "medium" by default ([#7157](#7157)) ([1b9a8ed](1b9a8ed)) * **alert:** Update alert queue when an alert is removed from the DOM ([#7189](#7189)) ([edd59eb](edd59eb)) * **combobox, dropdown, input-date-picker, input-time-picker, popover, tooltip:** Prevent repositioning from affecting other floating components ([#7178](#7178)) ([1b02dae](1b02dae)) * Ensure mouse events are blocked for disabled components in Firefox ([#7107](#7107)) ([271d985](271d985)) * **input-date-picker:** Fix showing the placeholder when resetting the value ([#7156](#7156)) ([8d60ffd](8d60ffd)) * **input, input-number:** Allows numeric characters. ([#7213](#7213)) ([739f0af](739f0af)) * **input,input-number:** Allow typing decimal separator in firefox for arabic locale ([#7173](#7173)) ([595e6f2](595e6f2)) * **list:** No longer has incorrect border width ([a810943](a810943)) * **list:** Update selectedItems property on all item selection changes ([#7204](#7204)) ([da048f6](da048f6)) * **menu-item:** Ensure correct order of rendered icons ([#7098](#7098)) ([fd344e9](fd344e9)), closes [#7097](#7097) * **navigation:** Label is no longer a required property ([#7084](#7084)) ([ba2bd4d](ba2bd4d)) * **radio-button-group:** No longer focus first radio button on label click and adds `setFocus` method. ([#7050](#7050)) ([4267b8c](4267b8c)) * **radio-button, radio-button-group:** Prevent emitting events when selecting a checked radio button ([#7102](#7102)) ([77fcc81](77fcc81)) * **radio-button:** Focuses first focusable radio-button element in group. ([#7152](#7152)) ([dd7ec60](dd7ec60)) * **scrim:** Responsively set the scale of the loading spinner ([#7182](#7182)) ([72c5943](72c5943)) * **tooltip:** Improve component timing ([#7172](#7172)) ([106f5d2](106f5d2)) * **tree-item:** Ensure expanded tree-item is displayed when expanded and made visible ([#7216](#7216)) ([3c0fbf5](3c0fbf5)) <details><summary>@esri/calcite-components-react: 1.4.3</summary> ## [1.4.3](https://github.com/Esri/calcite-components/compare/@esri/[email protected]...@esri/[email protected]) (2023-06-26) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from 1.4.3-next.7 to 1.4.3 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ben Elan <[email protected]>
benelan
added a commit
that referenced
this pull request
Jun 27, 2023
…issue-template-checkbox * origin/master: (32 commits) ci: double build cc when publishing to workaround stencil types bug (#7227) build: bump package versions back to 1.5.0-next.5 (#7228) chore: release latest (#7144) ci: hardcode release version due to reverting feat (#7225) fix(tree-item): ensure expanded tree-item is displayed when expanded and made visible (#7216) ci(release-please): pin action version and allow manually running action (#7222) fix(input, input-number): allows numeric characters. (#7213) build(t9n): generate json file containing t9n values (#7214) chore: release next fix(combobox, dropdown, input-date-picker, input-time-picker, popover, tooltip): Prevent repositioning from affecting other floating components (#7178) build: update browserslist db (#7192) build: ignore node_modules and build outputs when watching for changes during stencil tests (#7209) test: set up `disabled` helper to run a test per use case (#7089) ci: set design complete label conditionals (#7206) chore: release next fix(list): update selectedItems property on all item selection changes (#7204) chore: fix sorting logic for t9nmanifest entries (#7203) fix(radio-button): focuses first focusable radio-button element in group. (#7152) chore: release next fix(alert): update alert queue when an alert is removed from the DOM (#7189) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6616
Summary
calciteInternalAlertUnregisterto dispatch when an alert is removed from the DOM.