Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pagination)!: remove deprecated event. #6020

Merged
merged 6 commits into from
Dec 14, 2022
Merged

refactor(pagination)!: remove deprecated event. #6020

merged 6 commits into from
Dec 14, 2022

Conversation

anveshmekala
Copy link
Contributor

Related Issue: #5798

BREAKING CHANGE: Removed deprecated event.

Removed the event calcitePaginationUpdate event, use calcitePaginationChange event instead.

@anveshmekala anveshmekala changed the title refactor(pagination): remove deprecated event. refactor(pagination)!: remove deprecated event. Dec 13, 2022
@anveshmekala anveshmekala added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Dec 13, 2022
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Dec 13, 2022
@anveshmekala anveshmekala marked this pull request as ready for review December 14, 2022 00:04
@anveshmekala anveshmekala requested a review from a team as a code owner December 14, 2022 00:04
driskull
driskull approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🥂

@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 14, 2022
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 14, 2022
@anveshmekala anveshmekala merged commit 34fde8b into master Dec 14, 2022
@anveshmekala anveshmekala deleted the anveshmekala/5798-pagination-deprecations branch December 14, 2022 16:27
@github-actions github-actions bot added this to the 2023 January Priorities milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

Assignees

@anveshmekala anveshmekala

Labels
breaking change Issues and pull requests with code changes that are not backwards compatible. pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2023 January Priorities
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @driskull