refactor(flow, flow-item)!: Adds open property to flow-item to control which panel should be displayed.
#4852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactor
# Conflicts: # src/components/flow/flow.tsx
# Conflicts: # src/components/flow/flow.e2e.ts
# Conflicts: # src/components/flow/flow.e2e.ts # src/components/flow/flow.tsx # src/components/panel/panel.tsx
…low panel should be displayed.
driskull
changed the title
|
@jcfranco do you want to discuss this PR soon? Besides the flow, the only other component that removes an element seems to be the pick list: https://github.com/Esri/calcite-components/blob/master/src/components/pick-list/shared-list-logic.ts#L201-L204 |
… built-in `hidden`
# Conflicts: # src/components/flow/flow.e2e.ts # src/components/flow/flow.scss # src/components/flow/flow.tsx
# Conflicts: # src/components/flow-item/flow-item.e2e.ts # src/components/flow-item/flow-item.scss # src/components/flow-item/flow-item.tsx # src/components/flow/flow.scss # src/components/flow/flow.tsx # src/demos/flow.html
driskull
changed the title
open property to panel to control which panel should be displayed.open property to flow-item to control which panel should be displayed.
# Conflicts: # src/components/flow-item/flow-item.tsx
# Conflicts: # src/components/flow-item/flow-item.tsx # src/components/flow/flow.e2e.ts
driskull
changed the title
open property to flow-item to control which panel should be displayed.open property to flow-item to control which panel should be displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5072
Summary
refactor(flow, flow-item)!: Adds
openproperty to flow-item to control which panel should be displayed.BREAKING CHANGE: The
openproperty must be defined to display a specificflow-itemwithin a flow.