Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(color-picker)!: update color field dimensions #10903

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 27, 2024

Related Issue: #9415

Summary

This updates the color-picker's default widths to be:

  • 200 (s)
  • 240 (m)
  • 304 (l)

Additionally, the color-field will use an aspect ratio of 1.8.

BREAKING CHANGE: The default width and height of the color-picker have been updated. Developers should review and adjust their layouts to accommodate these changes.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Nov 27, 2024
@jcfranco jcfranco changed the title feat(color-picker)!: update color field widths and use 1.8 ratio feat(color-picker)!: update color field dimensions Nov 27, 2024
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Nov 27, 2024
@jcfranco
Copy link
Member Author

Responsiveness will be added in #10904. cc @geospatialem

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 27, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 27, 2024
Copy link

@ashetland ashetland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visuals lookin' purty

@jcfranco jcfranco merged commit 7fc2ab8 into dev Nov 27, 2024
14 checks passed
@jcfranco jcfranco deleted the jcfranco/9415-update-color-picker-base-dimensions branch November 27, 2024 23:02
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants