-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chip): add closeOnDelete
prop
#10877
feat(chip): add closeOnDelete
prop
#10877
Conversation
closeOnEscape
prop to close a closable chip via keyboardcloseOnEscape
prop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple q:
- Could you update the title from
closeOnEscape
? - This works when both the entire chip is focused and when the close button itself is focused. Just confirming we want this to happen in both cases (I think we do)
- Should this also include backspace support? If so, do we need a different name (closeOnKeyboard... etc)
closeOnEscape
propcloseOnDelete
prop
@macandcheese Excellent questions:
|
Yeah - tough one to name. Some keyboards (mainly ones marketed for Mac) have "delete" written on the backspace key anyway. For some laptops there is no "delete" standalone anyway. All that to say - maybe |
Proceeding with |
Related Issue: #6825
Summary
This prop will allow developers to configure whether a chip will close on
Delete
when focused.