Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: drop obsolete componentOnReady util #10857

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

refactor: drop obsolete componentOnReady util #10857

wants to merge 3 commits into from
+21 −81

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 23, 2024 •
edited
Loading

Related Issue: N/A

Summary

Lumina provides componentOnReady for both lazy and non-lazy outputs, so this util is no longer necessary.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Nov 23, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcfranco jcfranco

Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jcfranco