Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore stylelint known custom functions #10840

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Nov 22, 2024

Related Issue: N/A

Summary

Restores customFunctions to prevent function-no-unknown errors.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Nov 22, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 22, 2024
@jcfranco jcfranco requested review from macandcheese and anveshmekala and removed request for anveshmekala November 22, 2024 08:11
"medium-modular-scale",
"modular-scale",
"scale-duration",
"small-modular-scale"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a trailing comma to match the rest of the file? When this auto-generated for me it had one 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine.

I wonder if the trailing comma was added by VSCode. Our linting doesn't apply to *.cjs files, although I think we might want to revisit that. cc @benelan

Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants