Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(themed): simplify the test #10829

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
+1 −1
Open

test(themed): simplify the test #10829

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c192c21
test(themed): simplify the test
alisonailea Oct 29, 2024
3e8905b
chore(themed): remove comments
alisonailea Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/calcite-components/src/tests/commonTests/themed.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ async function assertThemedProps(page: E2EPage, options: TestTarget): Promise<vo
const isLinearGradientUnderlineToken = token.includes("link-underline-color") && targetProp === "backgroundImage";

if (isFakeBorderColorToken || isLinearGradientUnderlineToken) {
expect(getStyleString(token, targetProp, styles[targetProp])).toMatch(expectedValue);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep this for testing maintenance. Removing getStyleString would remove helpful details from the test failure messages (see #9481).

expect(styles[targetProp]).toContain(expectedValue);
return;
}

Expand Down
Loading