Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tokens)!: correct space and size tokens #10727

Merged
merged 31 commits into from
Nov 27, 2024
Merged

fix(tokens)!: correct space and size tokens #10727

merged 31 commits into from
Nov 27, 2024

Commits on Nov 15, 2024

  1. chore(token-transformer): add pxToRem helper

    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    05a36b9 View commit details
    Browse the repository at this point in the history

  2. fix(size): align core token size “category” with “type”

    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ad370c4 View commit details
    Browse the repository at this point in the history

  3. fix(size)!: correct size tokens 

    BREAKING CHANGES

moves all old pixel based size tokens to a “fixed” category and marks them for deprecation.
new default size tokens are different sizes
new default size tokens convert to REMs when built for web platforms
    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    16da23c View commit details
    Browse the repository at this point in the history

  4. fix(space)!: correct space tokens 

    BREAKING CHANGES

moves all old pixel based space tokens to a “fixed” category and marks them for deprecation.
new default space tokens are different values
new default space tokens convert to REMs when built for web platforms
    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    844c145 View commit details
    Browse the repository at this point in the history

  5. test(tokens): update snapshot

    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    11154f1 View commit details
    Browse the repository at this point in the history

  6. fix(tokens): remove extra fixed size tokens

    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    9af6d1d View commit details
    Browse the repository at this point in the history

  7. fix(tokens): remove extra fixed size tokens

    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d6ea2c2 View commit details
    Browse the repository at this point in the history

  8. test(tokens): update snapshot

    @alisonailea @jcfranco
    alisonailea authored and jcfranco committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    2569cfb View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. fix(tokens): update size tokens to match new uikit

    @alisonailea
    alisonailea committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e53910a View commit details
    Browse the repository at this point in the history

  2. test(tokens): update snapshot

    @alisonailea
    alisonailea committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    aad4a43 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Merge branch 'dev' of github.com:Esri/calcite-design-system into ali-… 

    …openPR/10012-10014-space-size-tokens
    @alisonailea
    alisonailea committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2cc449e View commit details
    Browse the repository at this point in the history

  2. chore(tokens): revert “space” token name for “spacing”

    @alisonailea
    alisonailea committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f736f8f View commit details
    Browse the repository at this point in the history

  3. chore(tokens): add style-dictionary valuetToUnitless helper

    @alisonailea
    alisonailea committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    7740cc9 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. test(tokens): update snapshot

    @alisonailea
    alisonailea committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    953ed86 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Merge branch 'dev' of github.com:Esri/calcite-design-system into astu… 

    …mp/10012-10014-space-size-tokens

# Conflicts:
#	packages/calcite-design-tokens/support/tests/__snapshots__/index.spec.ts.snap
    @alisonailea
    alisonailea committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    533b9e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. chore(custom-theme): revert to dev

    @alisonailea
    alisonailea committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    b385606 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' of github.com:Esri/calcite-design-system into astu… 

    …mp/10012-10014-space-size-tokens
    @alisonailea
    alisonailea committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    e266f96 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into astump/10012-10014-space-size-tokens

    @alisonailea
    alisonailea authored Nov 26, 2024
    Configuration menu
    Copy the full SHA
    7bc42ee View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2024

  1. fix(legacy, action, card-group, date-picker-month-header, date-picker… 

    …-month, dialog, dropdown-item, input-date-picker, panel, select, tab-nav, text-area, tile, tree-item, validation): update size space tokens
    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    e117a2b View commit details
    Browse the repository at this point in the history

  2. fix(card-group, date-picker-month-header, panel): resolve misreferenc… 

    …ed tokens
    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    0fcf249 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'dev' into astump/10012-10014-space-size-tokens

    @alisonailea
    alisonailea authored Nov 27, 2024
    Configuration menu
    Copy the full SHA
    24b7461 View commit details
    Browse the repository at this point in the history

  4. fix(panel): update space tokens

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    69d41fe View commit details
    Browse the repository at this point in the history

  5. Merge branch 'astump/10012-10014-space-size-tokens' of github.com:Esr… 

    …i/calcite-design-system into ali-openPR/10012-10014-space-size-tokens-refactor
    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    c651f7b View commit details
    Browse the repository at this point in the history

  6. fix(panel): resolve token

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    4ad7326 View commit details
    Browse the repository at this point in the history

  7. fix(panel): token values

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3302076 View commit details
    Browse the repository at this point in the history

  8. fix(action-group): set missing border

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2085fd8 View commit details
    Browse the repository at this point in the history

  9. fix(panel): tokens

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    f18208b View commit details
    Browse the repository at this point in the history

  10. fix(scrim): remove unnecessary token assignment

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    2a1e590 View commit details
    Browse the repository at this point in the history

  11. fix(panel): tokens

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    3fd82a1 View commit details
    Browse the repository at this point in the history

  12. Revert "fix(panel): tokens" 

    This reverts commit f18208b.
    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    18eb8ea View commit details
    Browse the repository at this point in the history

  13. fix(panel): switch tokens to align with original values

    @alisonailea
    alisonailea committed Nov 27, 2024
    Configuration menu
    Copy the full SHA
    96e2147 View commit details
    Browse the repository at this point in the history