Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flow: do not remove child items from the DOM when drilling #5072

Closed
benelan opened this issue Aug 2, 2022 · 7 comments
Closed

Flow: do not remove child items from the DOM when drilling #5072

benelan opened this issue Aug 2, 2022 · 7 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. spike complete Issues that have a research spike completed and dev work can proceed
Milestone
2024-11-26 - 3.0....

Comments

@benelan
Copy link
Member

benelan commented Aug 2, 2022

Description

Update calcite-flow to no longer remove a calcite-flow-item from the DOM when drilling. Instead, a selected property should be added to calcite-flow-item to determine which item is actively visible instead of assuming the last child item in a flow wins. The calcite-flow will be updated to look at the selected property of a calcite-flow-item.

Acceptance Criteria

  • Flow Items are no longer removed from the DOM when drilling.
  • New selected property on Flow Item is used instead

Relevant Info

blocked until #5071 is completed

Which Component

calcite-flow
calcite-flow-item

Example Use Case

No response
@benelan benelan added enhancement Issues tied to a new feature or request. 1 - assigned Issues that are assigned to a sprint and a team member. blocked This issue is blocked by another issue. needs triage Planning workflow - pending design/dev review. labels Aug 2, 2022
@benelan benelan added this to the Sprint 2022/08/08 - 2022/08/19 milestone Aug 2, 2022
@benelan benelan removed the needs triage Planning workflow - pending design/dev review. label Aug 2, 2022
@driskull driskull mentioned this issue Sep 7, 2022
Closed
@driskull
Copy link
Member

driskull commented Sep 14, 2022 •
edited
Loading

@benelan @jcfranco Is this something we want to do pre 1.0?

If we add an open property to the flow-item, to support it in flow we would also probably need to add an open property to panel which I don't think we want to do. Introducing a new open property and immediately deprecating it doesn't sound like a great idea.

@geospatialem geospatialem added breaking change Issues and pull requests with code changes that are not backwards compatible. and removed blocked This issue is blocked by another issue. labels Nov 14, 2022
@geospatialem geospatialem mentioned this issue Nov 14, 2022
Closed
@driskull driskull removed their assignment Nov 18, 2022
@driskull driskull added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 18, 2022
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed needs triage Planning workflow - pending design/dev review. labels May 9, 2024
@geospatialem
Copy link
Member

@driskull We're looking for a spike for an initial prototype of what we could achieve in an upcoming breaking change release WRT the flow and flow-item behavior above.

@driskull
Copy link
Member

Sounds good @geospatialem. I can work on this.

@jcfranco jcfranco mentioned this issue May 17, 2024
Closed
driskull added a commit that referenced this issue May 21, 2024
@driskull
feat(flow, flow-item)!: add selected property to flow-item instead of…
a25851a 
… removing them from the DOM. #5072
@driskull driskull mentioned this issue May 21, 2024
Merged
@driskull
Copy link
Member

@geospatialem have prototype here: #9390

Can we unspike this? 🌵

@geospatialem geospatialem added the spike complete Issues that have a research spike completed and dev work can proceed label May 21, 2024
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. 1 - assigned Issues that are assigned to a sprint and a team member. labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone May 21, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 21, 2024
@maxpatiiuk maxpatiiuk mentioned this issue May 29, 2024
Open
6 tasks
@driskull driskull mentioned this issue Oct 29, 2024
Open
driskull added a commit that referenced this issue Oct 31, 2024
@driskull
feat(flow, flow-item)!: avoids removing flow-items from the DOM and a…
c150492 
…dds selected property (#9390)

**Related Issue:** #5072

## Summary

- Add `selected` property to `calcite-flow-item`.
- Sets the last `calcite-flow-item` as `selected` if no other is
`selected.
- Requires custom classes implementing `FlowItemLikeElement` to have a
`selected` property
- Cleans up animation by removing class after animation is complete
- update tests
- update demo and add placeholder image (the url is slow)
- update stories

BREAKING CHANGE: The new `selected` property on `calcite-flow-item` must
be used to define which `calcite-flow-item` is shown.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Oct 31, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 20, 2024

🍡 Verified on 3.0.0-next.18

@DitwanP DitwanP closed this as completed Nov 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (dev) Issues logged by Calcite developers. enhancement Issues tied to a new feature or request. spike complete Issues that have a research spike completed and dev work can proceed
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
6 participants
@jcfranco @driskull @alisonailea @geospatialem @benelan @DitwanP