Lock state.block table when performing non-atomic read/write #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should prevent the duplicate key errors we have seen in production from the preconfirmations node, which runs two simultaneous tasks that both update the blocks table.
nomaxg
reviewed
Oct 9, 2023
| // already exists) and modify it. These two actions do not happen atomically; without | ||
| // protection, another transaction may complete and modify the state.block table in between. | ||
| // Thus, we first need to acquire a lock that prevents concurrent updates to the table. | ||
| if _, err := e.Exec(ctx, "LOCK TABLE state.block IN EXCLUSIVE MODE"); err != nil { |
There was a problem hiding this comment.
What is the scope of the client session? Just wondering if we need to unlock explicitly
There was a problem hiding this comment.
Postgres has no explicit unlock command. All locks are dropped when the transaction is committed or rolled back
There was a problem hiding this comment.
nomaxg
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent the duplicate key errors we have seen in production from the preconfirmations node, which runs two simultaneous tasks that both update the blocks table.