Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Check ERC20 address matches registered address #968

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Check ERC20 address matches registered address #968

merged 2 commits into from
Apr 20, 2022

Conversation

sveitser
Copy link
Contributor

  • Add test for deposit with wrong ERC20 address
  • Some refactoring to make the test code more concise.

Close #954

philippecamacho
philippecamacho approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@philippecamacho philippecamacho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sveitser sveitser merged commit 7fc72c3 into main Apr 20, 2022
@sveitser sveitser deleted the fix/t954-deposit-check-token-address branch April 20, 2022 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alxiong alxiong alxiong left review comments

@philippecamacho philippecamacho philippecamacho approved these changes

@jbearer jbearer jbearer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deposit function does not check if ERC20 address matches that of registered asset definition
4 participants
@sveitser @philippecamacho @jbearer @alxiong