remove consensus, extraneous parameter for update_view, repoint deps #3755
Conversation
|
|
pls148
force-pushed
the
ps/3640
branch
6 times, most recently
from
f81c9ca
to
300d0eb
Compare
|
This looks good. However I think now the CI is redundant. The ci jobs for test and test-dependency-tasks are running the same tests now I think. In a follow up can you confirm that the sets of tests are the same and remove one of them? Future follow up is to pick out the now unused or misused types/functions and types in task-impl helpers (and other places) |
There was a problem hiding this comment.
I think the feature also appears in a few Cargo.toml files, and should be removed from there
For CI, you can also just delete the block called test-dependency-tasks in .github/workflows/build-and-test.yml (keeping the regular tests, which now always run the dependency tasks)
|
I've added another commit which removes dependency-tasks from CI and Cargofiles, for the rest of the stuff I'm going to make a follow-up PR to avoid blocking 3738 |
Closes #3640
This PR:
This PR removes the consensus module (deprecated in favor of consensus2) and removes an extra parameter for update_view. Also removes references to the "dependency-tasks" feature.
This PR does not:
This does NOT rename the consensus2 module to consensus, nor change any other types. That will come in a later PR.
Key places to review: