[CX_HARDENING] - Delete Legacy Consensus

[jparr721]

What is this task and why do we need to work on it?

This is straightforward. Go in and delete the consensus module and clean up the compiler errors. This should include a check of the duplicated functions, however, before removal. In particular

• update_view
• handle_quorum_proposal_validated
• create_and_send_proposal

The purpose of these checks is to make sure that things like upgrade logic etc is included in the new code paths. We also need to rename consensus2 to consensus.

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

• HotShot only has one consensus module.
• The dependency tasks are stable and deployed in all relevant environments.

Branch work will be merged to (if not the default branch)

No response

[pls148]

#3755 erroneously closed this issue, reopening as there will be additional PRs landing here.

[pls148]

Keeping the remaining work organized here:

• DCE: pick out the now unused or misused types/functions and types in task-impl helpers (and other places)
• Rename consensus2->consensus
• Clean up any other bits relating to dependency-tasks