Update h5p/h5p-editor dependency

[andrewmile]

This PR updates the h5p/h5p-editor dependency to 1.25 in order to remove the deprecation warnings when running on PHP 8.0 or higher.

This PR will close #172

[qunabu]

There are some braking changes we need to adapt in our code as you can see why test are failing

[andrewmile]

Thanks @qunabu , I'm happy to take a look at the breaking changes if that's okay with you. Can you share your process for running the tests locally?

[qunabu]

Thanks @qunabu , I'm happy to take a look at the breaking changes if that's okay with you. Can you share your process for running the tests locally?

https://github.com/EscolaLMS/H5P#running-test-locally

[andrewmile]

Thanks for this update. ./test.sh made it easy 👍. It looks like we're stuck on this until H5P tags a 1.25 release.

I made some notes below on the related failing tests for reference. Feel free to close the PR if you'd prefer not to wait for the tag.

Failing Tests

Api\AjaxLibraryApiTest::testAjaxUploadLibraryAdmin

Call to undefined method H5PCore::libraryToFolderName() in vendor/h5p/h5p-editor/h5peditor.class.php:628

• This method is called from H5pEditor::mergeLocalLibsIntoCachedLibs
• This looks to be due to requiring 1.25 of h5p/h5p-editor and 1.24 of h5p/h5p-core
• h5p/h5p-core does not yet have a tag for 1.25 but it does have moodle-1.25 and Drupal-7.x-1.25
• There is an issue opened related to this and a commenter asking for them to tag the release

Api\LibraryLanguageApiTest::testGetEditorLibraryShouldUpdateTranslationFromLocalRepo

Call to undefined method H5PCore::libraryToFolderName() in vendor/h5p/h5p-editor/h5peditor.class.php:406

• Same as above but called from H5PEditor::getLibraryData

[qunabu]

@daVitekPL can you have a look on those ? please merge or close this

[gitguardian]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9556662	Triggered	Generic Password	d4f05cf	.github/workflows/phpstan.yml	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secret safely. Learn here the best practices.
3. Revoke and rotate this secret.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

[daVitekPL]

I am closing this PR because I created a new PR where I updated h5p/h5p-core to version 1.26 and fixed the tests that were failing.