Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0][IMP] egd_purchase_custom: add payment_term_id field to report_purchasequotation_document and report_purchaseorder_document #29

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

augustodinizl
Copy link
Contributor

No description provided.

@augustodinizl augustodinizl changed the title add_payment_terms [IMP] Add payment_term_id field to report_purchasequotation_document and report_purchaseorder_document Dec 1, 2023
Copy link
Contributor

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@augustodinizl Faltou um ponto importante tbm a importação do arquivo no __manifest__.py

Copy link
Contributor

@kaynnan kaynnan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Referente ao históricos de commit, faz um git rebase -i HEAD~3 e junta com o comando squash no lugar de pick de baixo para cima até que fique somente um commit

Exemplo:

image

Quando passar para a próxima etapa vc consegue ajustar a mensagem do commit tbm no caso, deixa somente como:

[IMP] egd_purchase_custom: add template custom

image

Assim que atualizar da o push para subir as alterações

@kaynnan
Copy link
Contributor

kaynnan commented Dec 5, 2023

@augustodinizl Outro erro que ocorre é na instalação do módulo por conta do id colocado nos templates:

id="purchase_stock.report_purchasequotation_document_egd"

Dessa maneira o Odoo tenta localizar dentro do módulo purchase_stock, o correto para declaração dos id seria:

id="egd_inherit_report_purchasequotation_document" e id="egd_inherit_report_purchaseorder_document"

Ajustando esses erros mencionados, o template funciona corretamente:

image
image

@augustodinizl augustodinizl changed the title [IMP] Add payment_term_id field to report_purchasequotation_document and report_purchaseorder_document [14.0][IMP] Add payment_term_id field to report_purchasequotation_document and report_purchaseorder_document Dec 5, 2023
@kaynnan kaynnan changed the title [14.0][IMP] Add payment_term_id field to report_purchasequotation_document and report_purchaseorder_document [14.0][IMP] egd_purchase_custom: add payment_term_id field to report_purchasequotation_document and report_purchaseorder_document Dec 5, 2023
@marcelsavegnago
Copy link
Contributor

Opa.. PR pronta ? Se sim coloca ela como pronta para revisão por favor

@augustodinizl
Copy link
Contributor Author

Opa.. PR pronta ? Se sim coloca ela como pronta para revisão por favor

já fiz todas as alterações, o que tá blockando é o seu change request...

@marcelsavegnago marcelsavegnago merged commit a0f807c into Escodoo:14.0 Dec 11, 2023
2 of 4 checks passed
@marcelsavegnago
Copy link
Contributor

@augustodinizl adiciona na task uma atividade para subir para o ambiente staging e prod por favor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants