update nuget, add logic to solve https://github.com/EricZimmerman/evtx/issues/230 #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will do the math to treat 4600 as the start, 4700 as the end, and not fall over
|
nice try skynet. not this time. I rolled my own solution thats less convoluted. please check it out and try it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update nuget packages
adds logic to resolve #230
This seemed like an easy one for ChatGPT to handle. @EricZimmerman feel free to modify as you see fit, of course, but I tested it and it works.
I also added logic to handle where if someone tries to pass
4700-4600so it'll handle 4600 as the start, 4700 as the end, and iterate accordingly.So tests with both
--incand--exchave passed using both4600-4700and4700-4600.