Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix imports in pyproject.toml #28

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

MaloChevillotte
Copy link
Contributor

@MaloChevillotte MaloChevillotte commented Dec 16, 2024

Fixes EXP-4274
Our new Python packaging that moved from setup.py to pyproject.toml was introduced with PR 26. We used the include-package-data which only imports non-.py file from the current directory. eppo_metric_schema.json is in the schema directory and was not imported when users ran pip install. That lead to Strava pinning to version 0.1.2 because our latest release throws back an error message. Potentially all customers using this package will be impacted when running pip install eppo_metrics_sync.

Current change should fix it as per Perplexity
Screenshot 2024-12-16 at 5 56 43 PM

Testing

  • Verified package builds locally using python -m build, locally installed the package from eppo_metrics_sync-0.1.4.tar.gz and ran a sync to QA.

@MaloChevillotte MaloChevillotte merged commit f6231d5 into main Dec 17, 2024
1 check passed
@MaloChevillotte MaloChevillotte deleted the malo/fix-schema-not-imported branch December 17, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants