Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes EXP-4274
Our new Python packaging that moved from
setup.py
topyproject.toml
was introduced with PR 26. We used theinclude-package-data
which only imports non-.py file from the current directory.eppo_metric_schema.json
is in theschema
directory and was not imported when users ran pip install. That lead to Strava pinning to version 0.1.2 because our latest release throws back an error message. Potentially all customers using this package will be impacted when running pip installeppo_metrics_sync
.Current change should fix it as per Perplexity
Testing
python -m build
, locally installed the package fromeppo_metrics_sync-0.1.4.tar.gz
and ran a sync to QA.