Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niko/dotnet new template #554

Merged
merged 12 commits into from
Jan 17, 2025
Merged

Niko/dotnet new template #554

merged 12 commits into from
Jan 17, 2025

Conversation

nikomancy
Copy link
Contributor

@nikomancy nikomancy commented Dec 16, 2024

What?

Breaking out the Dotnet docs into the multipage template we use for Javascript.

Why?

  • The goal is to make the learning journey for engineers working with specific SDKs easier.
  • Content is easier to find in the TOC improving navigability.
  • Code samples for typed examples have been added for ease of use.
  • Boilerplate prose docs have been added to allow engineers to learn about relevant conceptual information along side the code without having to context switch to other parts of the docs.

Todo before merge

  • Update redirects
  • delete dotnet.md

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for eppo-data-docs ready!

Name Link
🔨 Latest commit e7b2018
🔍 Latest deploy log https://app.netlify.com/sites/eppo-data-docs/deploys/678aa4d15c2fe000087ca223
😎 Deploy Preview https://deploy-preview-554--eppo-data-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@typotter typotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall.
Mostly just nits. Thanks Niko!

docs/sdks/server-sdks/dotnet/quickstart.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/quickstart.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/quickstart.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/quickstart.mdx Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/quickstart.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/assignments.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/bandits.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/bandits.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/bandits.mdx Outdated Show resolved Hide resolved
docs/sdks/server-sdks/dotnet/bandits.mdx Outdated Show resolved Hide resolved
@typotter typotter self-requested a review January 16, 2025 17:34
@nikomancy nikomancy merged commit faf91cc into main Jan 17, 2025
4 checks passed
@nikomancy nikomancy deleted the niko/dotnet-new-template branch January 17, 2025 18:53

How the SDK fetches, serves, and caches experiment configurations is configurable via the `EppoClientConfig` class:

<ApiOptionRef
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

Comment on lines +102 to +106
// Example showing how to initialize with a shorter polling interval for more frequent updates
var config = new EppoClientConfig("<SDK_KEY>", myLogger)
{
PollingIntervalInMillis = 5000 // Update cache every 5 seconds
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants