dictionary updates #320
Open
dictionary updates #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding entry for fill_model_visibilities
There was a problem hiding this comment.
fill_model_visibilities is hardcoded to 1 in the model generation code. Do we want this to be changed on input?
Default for beam_nfreq_avg is 1 within the codebase. Default for beam_nfreq_avg is 16 within the eor_wrapper_defaults, which is perhaps were the confusion came from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to get these in, we need them! @dstorer and @PyxieLouStar maybe you can expand the description on
no_frequency_flagging? It's a little terse at the moment.