lint: Use biome instead of eslint

biome.json

@@ -13,6 +13,19 @@
 				"noUselessCatch": "error",
 				"noWith": "error"
 			},
+			"style": {
+				"noVar": "error",
+				"useFilenamingConvention": "error",
+				"useImportType": "error",
+				"useNamingConvention": {
+					"level": "warn",
+					"options": {
+						"strictCase": false
+					}
+				},
+				"useTemplate": "warn",
+				"useConst": "error"
+			},
 			"correctness": {
 				"noConstAssign": "error",
 				"noConstantCondition": "error",
@@ -70,7 +83,9 @@
 		},
 		"ignore": [
 			"**/npm node_modules",
-			"**/build"
+			"**/build",
+			"**/dist",
+			"**/src/i18n/locales"
 		]
 	},
 	"overrides": [

src/@types/i18next.d.ts

@@ -1,4 +1,4 @@
-import { resources } from "src/i18n/i18next";
+import type { resources } from "src/i18n/i18next";
 
 declare module "i18next" {
 	interface CustomTypeOptions {

src/GitHub/branch.ts

@@ -1,9 +1,9 @@
-import { Properties } from "@interfaces/main";
-import { Octokit } from "@octokit/core";
+import type { Properties } from "@interfaces/main";
+import type { Octokit } from "@octokit/core";
 import i18next from "i18next";
 import { Notice } from "obsidian";
 import { FilesManagement } from "src/GitHub/files";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import { logs, notif } from "src/utils";
 
 export class GithubBranch extends FilesManagement {
@@ -53,7 +53,7 @@ export class GithubBranch extends FilesManagement {
 				i18next.t("publish.branch.success", { branchStatus: branch.status, repo: prop })
 			);
 			return branch.status === 201;
-		} catch (e) {
+		} catch (_e) {
 			// catch the old branch
 			try {
 				const allBranch = await this.octokit.request(
@@ -90,25 +90,25 @@ export class GithubBranch extends FilesManagement {
 
 	async pullRequestOnRepo(prop: Properties): Promise<number> {
 		try {
-			const PR = await this.octokit.request("POST /repos/{owner}/{repo}/pulls", {
+			const pr = await this.octokit.request("POST /repos/{owner}/{repo}/pulls", {
 				owner: prop.owner,
 				repo: prop.repo,
 				title: i18next.t("publish.branch.prMessage", { branchName: this.branchName }),
 				body: "",
 				head: this.branchName,
 				base: prop.branch,
 			});
-			return PR.data.number;
+			return pr.data.number;
 		} catch (e) {
 			logs({ settings: this.settings, e: true }, e);
 			//trying to get the last open PR number
 			try {
-				const PR = await this.octokit.request("GET /repos/{owner}/{repo}/pulls", {
+				const pr = await this.octokit.request("GET /repos/{owner}/{repo}/pulls", {
 					owner: prop.owner,
 					repo: prop.repo,
 					state: "open",
 				});
-				return PR.data[0]?.number || 0;
+				return pr.data[0]?.number || 0;
 			} catch (e) {
 				// there is no open PR and impossible to create a new one
 				notif(
@@ -130,7 +130,7 @@ export class GithubBranch extends FilesManagement {
 	async deleteBranchOnRepo(prop: Properties): Promise<boolean> {
 		try {
 			const branch = await this.octokit.request(
-				"DELETE" + " /repos/{owner}/{repo}/git/refs/heads/" + this.branchName,
+				`DELETE /repos/{owner}/{repo}/git/refs/heads/${this.branchName}`,
 				{
 					owner: prop.owner,
 					repo: prop.repo,
@@ -161,8 +161,11 @@ export class GithubBranch extends FilesManagement {
 				{
 					owner: prop.owner,
 					repo: prop.repo,
+					// biome-ignore lint/style/useNamingConvention: hey, say that to github!
 					pull_number: pullRequestNumber,
+					// biome-ignore lint/style/useNamingConvention: hey, say that to github!
 					commit_title: commitMsg,
+					// biome-ignore lint/style/useNamingConvention: hey, say that to github!
 					merge_method: "squash",
 				}
 			);
@@ -203,8 +206,8 @@ export class GithubBranch extends FilesManagement {
 		try {
 			const pullRequest = await this.pullRequestOnRepo(prop);
 			if (prop.automaticallyMergePR && pullRequest !== 0) {
-				const PRSuccess = await this.mergePullRequestOnRepo(pullRequest, prop);
-				if (PRSuccess) {
+				const prSuccess = await this.mergePullRequestOnRepo(pullRequest, prop);
+				if (prSuccess) {
 					await this.deleteBranchOnRepo(prop);
 					return true;
 				}

src/GitHub/delete.ts

@@ -1,26 +1,26 @@
 import {
-	Deleted,
+	type Deleted,
 	FIND_REGEX,
 	FolderSettings,
-	GitHubPublisherSettings,
-	GithubRepo,
-	MonoRepoProperties,
-	Properties,
+	type GitHubPublisherSettings,
+	type GithubRepo,
+	type MonoRepoProperties,
+	type Properties,
 } from "@interfaces";
-import { Octokit } from "@octokit/core";
+import type { Octokit } from "@octokit/core";
 import i18next from "i18next";
 import { Base64 } from "js-base64";
 import {
-	MetadataCache,
+	type MetadataCache,
 	normalizePath,
 	Notice,
 	parseYaml,
-	TAbstractFile,
+	type TAbstractFile,
 	TFile,
 	TFolder,
 	Vault,
 } from "obsidian";
-import { FilesManagement } from "src/GitHub/files";
+import type { FilesManagement } from "src/GitHub/files";
 import { logs, notif, trimObject } from "src/utils";
 import { isAttachment, verifyRateLimitAPI } from "src/utils/data_validation_test";
 import { frontmatterSettingsRepository } from "src/utils/parse_frontmatter";
@@ -218,7 +218,7 @@ export async function filterGithubFile(
 			isAttachment(file.file, settings.embed.unHandledObsidianExt);
 		if (
 			(file.file.includes(defaultName) ||
-				(behavior === FolderSettings.yaml && file.file.includes(root)) ||
+				(behavior === FolderSettings.Yaml && file.file.includes(root)) ||
 				(attachmentFolder.length > 0 && file.file.includes(attachmentFolder))) &&
 			!excludedFileFromDelete(file.file, settings) &&
 			(enabledAttachments || file.file.match("md$"))

src/GitHub/files.ts

@@ -1,17 +1,17 @@
-import {
+import type {
 	ConvertedLink,
 	GithubRepo,
 	LinkedNotes,
 	Properties,
 	PropertiesConversion,
 	Repository,
 } from "@interfaces/main";
-import { Octokit } from "@octokit/core";
-import { EmbedCache, LinkCache, TFile, TFolder } from "obsidian";
-import { getAPI, Link } from "obsidian-dataview";
+import type { Octokit } from "@octokit/core";
+import { type EmbedCache, type LinkCache, TFile, TFolder } from "obsidian";
+import { getAPI, type Link } from "obsidian-dataview";
 import { getImagePath, getReceiptFolder } from "src/conversion/file_path";
 import Publisher from "src/GitHub/upload";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import { logs } from "src/utils";
 import { isAttachment, isShared } from "src/utils/data_validation_test";
 import {
@@ -37,18 +37,18 @@ export class FilesManagement extends Publisher {
 
 	getSharedFiles(repo: Repository | null): TFile[] {
 		const files = this.vault.getMarkdownFiles();
-		const shared_File: TFile[] = [];
+		const sharedFile: TFile[] = [];
 		for (const file of files) {
 			try {
 				const frontMatter = this.metadataCache.getCache(file.path)?.frontmatter;
 				if (isShared(frontMatter, this.settings, file, repo)) {
-					shared_File.push(file);
+					sharedFile.push(file);
 				}
 			} catch (e) {
 				logs({ settings: this.settings, e: true }, e);
 			}
 		}
-		return shared_File;
+		return sharedFile;
 	}
 
 	/**
@@ -395,6 +395,7 @@ export class FilesManagement extends Publisher {
 				{
 					owner: repo.owner,
 					repo: repo.repo,
+					// biome-ignore lint/style/useNamingConvention: github api
 					tree_sha: branchToScan,
 					recursive: "true",
 				}

src/GitHub/upload.ts

@@ -1,4 +1,4 @@
-import {
+import type {
 	Deleted,
 	GitHubPublisherSettings,
 	MetadataExtractor,
@@ -10,25 +10,25 @@ import {
 	UploadedFiles,
 } from "@interfaces";
 import { LOADING_ICON } from "@interfaces/icons";
-import { Octokit } from "@octokit/core";
+import type { Octokit } from "@octokit/core";
 import i18next from "i18next";
 import { Base64 } from "js-base64";
 import {
 	arrayBufferToBase64,
-	FrontMatterCache,
-	MetadataCache,
+	type FrontMatterCache,
+	type MetadataCache,
 	normalizePath,
 	Notice,
 	TFile,
 	TFolder,
-	Vault,
+	type Vault,
 } from "obsidian";
 import { mainConverting } from "src/conversion";
 import { convertToHTMLSVG } from "src/conversion/compiler/excalidraw";
 import { getImagePath, getReceiptFolder } from "src/conversion/file_path";
 import { deleteFromGithub } from "src/GitHub/delete";
 import { FilesManagement } from "src/GitHub/files";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import { logs, noticeMobile, notif, notifError } from "src/utils";
 import {
 	checkEmptyConfiguration,
@@ -527,8 +527,9 @@ export default class Publisher {
 			for (const file of Object.values(metadataExtractor)) {
 				if (file) {
 					const contents = await this.vault.adapter.read(file);
-					const path =
-						this.settings.upload.metadataExtractorPath + "/" + file.split("/").pop();
+					const path = `${this.settings.upload.metadataExtractorPath}/${file
+						.split("/")
+						.pop()}`;
 					prop = Array.isArray(prop) ? prop : [prop];
 					for (const repo of prop) {
 						await this.uploadText(contents, path, file.split("/").pop(), repo);
@@ -556,11 +557,13 @@ export default class Publisher {
 			{
 				owner: prop.owner,
 				repo: prop.repo,
+				// biome-ignore lint/style/useNamingConvention: GitHub API :(
 				workflow_id: prop.workflowName,
 				ref: prop.branch,
 			}
 		);
 		while (!finished) {
+			// biome-ignore lint/correctness/noUndeclaredVariables: directly build with obsidianAPI
 			await sleep(10000);
 			const workflowGet = await octokit.request(
 				"GET /repos/{owner}/{repo}/actions/runs",
@@ -652,7 +655,7 @@ export default class Publisher {
 								);
 						}
 					}
-				} catch (e) {
+				} catch (_e) {
 					newLinkedFiles.push(file);
 				}
 				//pass non image file as they are updated basically by GitHub with checking the content (basic git behavior)

src/commands/create_link.ts

@@ -1,7 +1,7 @@
-import { MultiRepoProperties, Repository } from "@interfaces";
+import type { MultiRepoProperties, Repository } from "@interfaces";
 import i18next from "i18next";
-import { Command, Notice } from "obsidian";
-import GithubPublisher from "src/main";
+import { type Command, Notice } from "obsidian";
+import type GithubPublisher from "src/main";
 import { createLink } from "src/utils";
 import { isShared } from "src/utils/data_validation_test";
 import { frontmatterFromFile, getProperties } from "src/utils/parse_frontmatter";

src/commands/file_menu/file.ts

@@ -1,9 +1,9 @@
-import { Repository } from "@interfaces";
+import type { Repository } from "@interfaces";
 import i18next from "i18next";
-import { Menu, MenuItem, Platform, TFile } from "obsidian";
+import { type Menu, type MenuItem, Platform, type TFile } from "obsidian";
 import { shareOneNote } from "src/commands";
 import { ChooseRepoToRun } from "src/commands/suggest_other_repo_commands_modal";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import {
 	defaultRepo,
 	getRepoSharedKey,

src/commands/file_menu/folder.ts

@@ -1,9 +1,9 @@
-import { MonoRepoProperties, Repository } from "@interfaces";
+import type { MonoRepoProperties, Repository } from "@interfaces";
 import i18next from "i18next";
-import { Menu, MenuItem, Platform, TFolder } from "obsidian";
+import { type Menu, type MenuItem, Platform, type TFolder } from "obsidian";
 import { shareAllMarkedNotes } from "src/commands";
 import { ChooseRepoToRun } from "src/commands/suggest_other_repo_commands_modal";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import {
 	defaultRepo,
 	getRepoSharedKey,

src/commands/purge.ts

@@ -1,9 +1,9 @@
-import { MonoRepoProperties, Repository } from "@interfaces";
+import type { MonoRepoProperties, Repository } from "@interfaces";
 import i18next from "i18next";
-import { Command, Notice } from "obsidian";
-import { GithubBranch } from "src/GitHub/branch";
+import { type Command, Notice } from "obsidian";
+import type { GithubBranch } from "src/GitHub/branch";
 import { deleteFromGithub } from "src/GitHub/delete";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import { ListChangedFiles } from "src/settings/modals/list_changed";
 import { notif } from "src/utils";
 import { checkRepositoryValidityWithProperties } from "src/utils/data_validation_test";

src/commands/repository_validity.ts

@@ -1,7 +1,7 @@
-import { Repository } from "@interfaces";
+import type { Repository } from "@interfaces";
 import i18next from "i18next";
-import { Command, Notice } from "obsidian";
-import GithubPublisher from "src/main";
+import { type Command, Notice } from "obsidian";
+import type GithubPublisher from "src/main";
 import { checkRepositoryValidity } from "src/utils/data_validation_test";
 
 /**

src/commands/set.ts

@@ -1,6 +1,6 @@
 import i18next from "i18next";
-import { Command, TFile } from "obsidian";
-import GithubPublisher from "src/main";
+import { type Command, TFile } from "obsidian";
+import type GithubPublisher from "src/main";
 
 export function refreshOpenedSet(plugin: GithubPublisher) {
 	const findRepo = (file: TFile | null) => {

src/commands/share/all_notes.ts

@@ -1,10 +1,10 @@
-import { MonoRepoProperties, Repository, UploadedFiles } from "@interfaces";
+import type { MonoRepoProperties, Repository, UploadedFiles } from "@interfaces";
 import { ERROR_ICONS } from "@interfaces/icons";
 import i18next from "i18next";
-import { Command, FrontMatterCache, Notice, Platform, TFile } from "obsidian";
-import { GithubBranch } from "src/GitHub/branch";
+import { type Command, type FrontMatterCache, Notice, Platform, type TFile } from "obsidian";
+import type { GithubBranch } from "src/GitHub/branch";
 import { deleteFromGithub } from "src/GitHub/delete";
-import GithubPublisher from "src/main";
+import type GithubPublisher from "src/main";
 import { ListChangedFiles } from "src/settings/modals/list_changed";
 import {
 	createListEdited,

src/commands/share/edited_notes.ts

@@ -1,8 +1,8 @@
-import { MonoRepoProperties, Repository } from "@interfaces";
+import type { MonoRepoProperties, Repository } from "@interfaces";
 import i18next from "i18next";
-import { Command, Notice, TFile } from "obsidian";
-import { GithubBranch } from "src/GitHub/branch";
-import GithubPublisher from "src/main";
+import { type Command, Notice, type TFile } from "obsidian";
+import type { GithubBranch } from "src/GitHub/branch";
+import type GithubPublisher from "src/main";
 import { checkRepositoryValidityWithProperties } from "src/utils/data_validation_test";
 import {
 	frontmatterSettingsRepository,