Allow to setup the test mode folder with dry-run disabled

[Mara-Li]

Summary by CodeRabbit

• Refactor
  • Streamlined settings management by removing conditional checks for dry run configurations.
  • Enhanced data validation logic for dry run scenarios to rely on folder name presence.

[coderabbitai]

Walkthrough

The codebase has been updated to streamline the handling of dry run settings. The feature toggle for a dry run, previously controlled by an enable flag, has been deprecated. Now, the focus shifts to the presence of a folder name to determine dry run behavior, simplifying the configuration process and the code's decision-making logic.

Changes

File Path	Change Summary
src/settings.ts	Removed conditional dryRun.enable check; always create dryRun.folderName setting.
src/utils/.../data_validation_test.ts	Updated isInDryRunFolder to check for empty folderName instead of enable flag.

Poem

🐇
In the burrows of the code, a switch was tossed,
No more flags, just folders, no paths were lost.
A rabbit's leap forward, with logic so clean,
A dry run's new meaning, simply serene.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between f460aa1 and 029415f.

Files ignored due to path filters (2)

• src/i18n/locales/en.json is excluded by: !**/*.json
• src/i18n/locales/fr.json is excluded by: !**/*.json

Files selected for processing (2)

• src/settings.ts (1 hunks)
• src/utils/data_validation_test.ts (1 hunks)

Additional comments: 2

src/utils/data_validation_test.ts (1)

• 435-435: The logic for determining if a file is in the dry-run folder has been changed to check if the folderName is empty instead of checking the enable property. This change aligns with the PR's objective to decouple the dry-run folder setup from the dry-run mode's enablement.

src/settings.ts (1)

• 309-322: The conditional logic for creating a Setting for githubSettings.dryRun.folderName has been removed, which means the setting will now always be created regardless of the dry-run mode's enablement status. This change is consistent with the PR's objective to allow for the setup of a test mode folder even when the dry-run option is disabled.