feat: wal storage #608
feat: wal storage #608
Conversation
wai-wong-edb
force-pushed
the
ww-wal-storage
branch
from
a22bae6 to
2dde8e2
Compare
| @@ -68,6 +68,12 @@ resource "biganimal_cluster" "ha_cluster" { | |||
| size = "4 Gi" | |||
| } | |||
|
|
|||
| # wal_storage = { | |||
| # volume_type = "gp3" | |||
| # volume_properties = "gp3" | |||
There was a problem hiding this comment.
should we handle setting volume properties internally since it does not have properties like az
# volume_type = "azurepremiumstorage"
# volume_properties = "P1"
There was a problem hiding this comment.
oh for AWS/GCP? Possibly it could work but maybe we can do it in another PR as an enhancement so that they can remove volume_properties for AWS/GCP. As of right now I think I recall in the API(for BA anyways) the volume_properties have to match the volume_type otherwise it will throw an error
| }, | ||
| "size": schema.StringAttribute{ | ||
| Description: "Size of the volume. It can be set to different values depending on your volume type and properties.", | ||
| Required: true, |
There was a problem hiding this comment.
cannot be require=true in case of azurepremiumstorage
since each volumeproperty has size, iops and throughput predefined and associated with it.
There was a problem hiding this comment.
size is actually a mandatory field. In the request if I just put P1 and leave size as nil it will return with this:
biganimal_cluster.single_node_cluster: Creating...
╷
│ Error: status: 400 - Bad Request
│
│ with biganimal_cluster.single_node_cluster,
│ on resource.tf line 21, in resource "biganimal_cluster" "single_node_cluster":
│ 21: resource "biganimal_cluster" "single_node_cluster" {
│
│ must have required property 'clusterType'
│ must NOT have additional properties
│ must NOT have additional properties
│ must NOT have additional properties
│ must NOT have additional properties
│ must NOT have additional properties
│ must NOT have additional properties
│ must NOT have additional properties
│ must NOT have additional properties
however if I put P1 and give a size of 7 Gi I get the error:
biganimal_cluster.single_node_cluster: Creating...
biganimal_pgd.pgd_cluster: Destruction complete after 5s
╷
│ Error: status: 400 - Bad Request
│
│ with biganimal_cluster.single_node_cluster,
│ on resource.tf line 21, in resource "biganimal_cluster" "single_node_cluster":
│ 21: resource "biganimal_cluster" "single_node_cluster" {
│
│ Value of storage size must be between 4 Gi and 4 Gi
I guess a future improvement would be to fetch the list of azurepremiumstorage volume properties and their sizes so size can be optional if they select azurepremiumstorage. But I think we can have that as an enhancement
There was a problem hiding this comment.
volume_properties: P1
volume_type: P1
size: 4 (exact size associated with each volume_property)
so user need to fill above details, for it to work
There was a problem hiding this comment.
let provide link to volume storage ref in examples
wai-wong-edb
force-pushed
the
ww-wal-storage
branch
from
ce87365 to
e5d52f9
Compare
No description provided.