Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPS-141-v11 #8

Open
wants to merge 1 commit into
base: REL-11
Choose a base branch
from
Open

PPS-141-v11 #8

wants to merge 1 commit into from

Conversation

Semab-Tariq
Copy link
Contributor

Add Notarization related code inside for loop to avoid daily builds failures

@Semab-Tariq Semab-Tariq requested a review from sandeep-edb May 27, 2021 12:25
@Semab-Tariq
Copy link
Contributor Author

Hi @sandeep-edb can you please review/merge?

sandeep-edb
sandeep-edb reviewed May 30, 2021
View reviewed changes
Copy link
Contributor

@sandeep-edb sandeep-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is cmd_status changing? probably cmd_status=$! is required?

@Semab-Tariq
Copy link
Contributor Author

@sandeep-edb yes I guess cmd_status should be something like cmd_status=$! but please see
The same thing cmd_status=0 is already committed on the REL-10 branch here

@Semab-Tariq Semab-Tariq added the Not Ready For Merge If a pull request is still in development phase or require some more information from a team member label Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandeep-edb sandeep-edb sandeep-edb left review comments

Assignees
No one assigned
Labels
Not Ready For Merge If a pull request is still in development phase or require some more information from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Semab-Tariq @sandeep-edb