-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify which values are optional. #6346
Open
sonotley
wants to merge
9
commits into
develop
Choose a base branch
from
pem/register-agent-tweaks
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain that PEM will still create agent users even when pem-agent-user is provided.
sonotley
added
the
deploy
Add this label to a PR and it will automatically be deployed to netlify
label
Dec 12, 2024
github-actions
bot
temporarily deployed
to
pr-6346-pem-register-agent-tweaks
December 12, 2024 11:45
Inactive
github-actions
bot
temporarily deployed
to
pr-6346-pem-register-agent-tweaks
December 12, 2024 11:55
Inactive
github-actions
bot
temporarily deployed
to
pr-6346-pem-register-agent-tweaks
December 12, 2024 16:08
Inactive
github-actions
bot
temporarily deployed
to
pr-6346-pem-register-agent-tweaks
December 16, 2024 13:28
Inactive
Most changes are on this page https://deploy-preview-6346--edb-docs-staging.netlify.app/docs/pem/latest/registering_agent/ |
github-actions
bot
temporarily deployed
to
pr-6346-pem-register-agent-tweaks
December 16, 2024 13:40
Inactive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some suggestions. Accept/Reject as required.
edbjunwang
reviewed
Dec 17, 2024
Co-authored-by: nidhibhammar <[email protected]>
sonotley
commented
Dec 18, 2024
sonotley
commented
Dec 18, 2024
All comments addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify which values are optional.
Explain that PEM will still create agent users even when pem-agent-user is provided.