Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to PAS: DBMS_XMLDOMDOC corrections #6290 #6335

Merged
merged 11 commits into from
Dec 20, 2024

Conversation

ebgitelman
Copy link
Contributor

What Changed?

@ebgitelman ebgitelman requested a review from a team as a code owner December 9, 2024 22:12
@ebgitelman
Copy link
Contributor Author

@nidhibhammar @gvasquezvargas I had a few queries on this. Also, look at the string XMLTYPE and XMLType in text and make sure the difference in capitalization is correct. I also donm't think it always needed to be tagged...did what I thought was right there but it could be wrong so please take a look. I don't think it's critical either way.

One other note, which is that we don't have any standard that says to use quote marks for elements as they were in various spots in this content. I believe the one place we do use it is when indicating char. These instances looked like they were meant to be just single quotes, i.e., appearing in computer font on screen.

@gvasquezvargas
Copy link
Contributor

I added some comments here and there, but let's wait for @nidhibhammar to chime in, as she has more experience with this product.

ebgitelman and others added 10 commits December 18, 2024 09:09
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getchildnodes.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/getfirstchild.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/setattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/setattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
…ence/epas_compat_bip_guide/03_built-in_packages/18_dbms_xmldom/setattribute.mdx

Co-authored-by: gvasquezvargas <[email protected]>
@gvasquezvargas gvasquezvargas force-pushed the docs/edits_to_epas_pr6290 branch from a5241ee to 9f8a650 Compare December 18, 2024 14:09
Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are good to go now!

@gvasquezvargas gvasquezvargas merged commit 11c96f4 into develop Dec 20, 2024
2 checks passed
@gvasquezvargas gvasquezvargas deleted the docs/edits_to_epas_pr6290 branch December 20, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants