DOCS-757 - Adding ORIGIN_GROUP #6026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpe442
added
the
deploy
josh-heyer
force-pushed
the
DOCS-978-Full-Branch-5.6
branch
2 times, most recently
from
004687d to
d9e248d
Compare
|
This apparently has 287 changed files. That doesn't sound good. |
josh-heyer
force-pushed
the
DOCS-978-Full-Branch-5.6
branch
from
f3a615c to
6a4788c
Compare
josh-heyer
force-pushed
the
DOCS-757
branch
from
ee94bdc to
3d2b40e
Compare
|
⚠Rebased! Pull latest before continuing work. |
djw-m
reviewed
Sep 27, 2024
djw-m
reviewed
Sep 27, 2024
| @@ -122,10 +124,9 @@ Set `bdr.commit_scope` to `local` to use the PGD default async replication. | |||
|
|
|||
| ## Origin groups | |||
There was a problem hiding this comment.
This may be large enough to be its own page now.
There was a problem hiding this comment.
I see what you are saying in that it is long, but I am worried about its discoverability. As in It makes sense that it is on this page on commit scopes to me and I worry that if it was on its own page it would be hard to find.
djw-m
reviewed
Sep 27, 2024
djw-m
force-pushed
the
DOCS-978-Full-Branch-5.6
branch
from
9344e24 to
020e2dd
Compare
josh-heyer
force-pushed
the
DOCS-978-Full-Branch-5.6
branch
from
21d2539 to
eca95d5
Compare
…or new origin groups page.
… some language in the index.
djw-m
pushed a commit
that referenced
this pull request
Oct 15, 2024
* First pass at adding to reference. * Another pass at adding ORIGIN_GROUP to PGD reference. * small change. * small change. * Small changes. * Added line about how ORIGIN_GROUP is dynamic in example. * Small changes * Fiddles with wording. * More word fiddling. * Added backticks back in last sql block. * Some more verbiage for clarity. * Added deepToc to pick up ORIGIN_GROUP subsection of Origin groups section. * Removed reference to syntax sugar. * Moved Origin Groups to its own spot. * Added something about origin groups on index page for commit scopes for new origin groups page. * Changes in index. * Removed old Origin Groups section from Commit scopes page and changed some language in the index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.6 introduces ORIGIN_GROUP "syntax sugar" such that the ORIGIN_GROUP of a transaction dynamically refers to the bottommost group from which a transaction originates.