Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontpage expansion (and devguide and migrations section) #5935

Merged
merged 48 commits into from
Sep 17, 2024
Merged

Frontpage expansion (and devguide and migrations section) #5935

merged 48 commits into from
Sep 17, 2024

Conversation

djw-m
Copy link
Contributor

@djw-m djw-m commented Aug 13, 2024

Signed-off-by: Dj Walker-Morgan [email protected]

What Changed?

@djw-m djw-m requested a review from a team as a code owner August 13, 2024 11:08
@djw-m djw-m added deploy Add this label to a PR and it will automatically be deployed to netlify do not merge labels Aug 13, 2024
@djw-m djw-m force-pushed the poc/e10ai/frontpageexpansion branch from 73a8ec6 to 1df0d2e Compare August 13, 2024 11:09
@djw-m djw-m self-assigned this Aug 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 13, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-5935--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 13, 2024 11:18 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 13, 2024 14:37 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 13, 2024 14:52 Inactive
@djw-m djw-m force-pushed the poc/e10ai/frontpageexpansion branch from 0f0e5dc to 1a4ccae Compare August 15, 2024 09:53
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 15, 2024 10:02 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 15, 2024 10:20 Inactive
@djw-m djw-m force-pushed the poc/e10ai/frontpageexpansion branch from 8236d84 to aca5385 Compare August 19, 2024 16:49
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 19, 2024 16:58 Inactive
@djw-m djw-m changed the title DevGuide POC Frontpage expansion (and devguide and migrations section) Aug 22, 2024
@djw-m djw-m force-pushed the poc/e10ai/frontpageexpansion branch from e7003ad to 0f46993 Compare August 23, 2024 14:36
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 23, 2024 14:46 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 23, 2024 18:16 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 27, 2024 11:59 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 27, 2024 12:05 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 27, 2024 12:57 Inactive
@gvasquezvargas gvasquezvargas force-pushed the poc/e10ai/frontpageexpansion branch from 272ccd6 to 5f644b8 Compare August 27, 2024 17:08
@gvasquezvargas gvasquezvargas mentioned this pull request Aug 27, 2024
Closed
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 27, 2024 17:16 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion August 29, 2024 10:34 Inactive
@djw-m djw-m removed the do not merge label Sep 3, 2024
@djw-m djw-m force-pushed the poc/e10ai/frontpageexpansion branch from 502d571 to 596a8f7 Compare September 3, 2024 07:44
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 3, 2024 07:53 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 5, 2024 08:34 Inactive
@djw-m djw-m force-pushed the poc/e10ai/frontpageexpansion branch from f4af809 to 8e6fbd3 Compare September 5, 2024 08:54
@jpe442
Copy link
Contributor

jpe442 commented Sep 9, 2024

Overall looks good and navigation from top down seems natural. My eyes could probably use a darker color (maybe the darker green in our scheme?) for the different banners (e.g. KUBERNETES, MANANGEMENT AND MONITORING, etc) throughout Platforms and Tools and Extensions and Tools, for more contrast with the text.

jpe442
jpe442 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@jpe442 jpe442 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mlewandowski-edb
mlewandowski-edb reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mlewandowski-edb mlewandowski-edb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked my way through a review of about 1/2 the pages in the DMS documenation and left a few comments.

advocacy_docs/edb-postgres-ai/migration-etl/data-migration-service/terminology.mdx Outdated

EDB Postgres® AI Analytics Sync is a type of replication/migration supported by EDB Data Migration Service. EDB Postgres Advanced Server and Postgres source database snapshots are transformed into Delta Lake format in CSP Object Storage. This object storage is exposed as Storage Locations in the EDB Postgres AI Console.

## Apache Kafka
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jperozoa @ksnavely
Is there any reason to list Kafka in the terminology section? Do we expose any kafka components to the user?

@gvasquezvargas If we decide to keep Kafka here, we may want to mention that it is one of the components used by the service.

advocacy_docs/edb-postgres-ai/migration-etl/data-migration-service/terminology.mdx Outdated

CDC is a set of software design patterns used to determine and track changes in data sets by calculating *deltas*. EDB Data Migration Service uses CDC to stream changes from a database cluster to another.

## Debezium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to the question about whether Kafka should be included, should Debezium we listed? However, unlike Kafka, I think Debezium is actually referenced in the documentation as part of configuring the reader. Again, if we include it, we should probably mention that the service uses it to perform capture changes from the source database.

advocacy_docs/edb-postgres-ai/migration-etl/data-migration-service/supported_versions.mdx Outdated
---

<div id="supported_versions" class="registered_link"></div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where this would belong, but the DMS is currently only supports migrating to EDB hosted (i.e., BAH) EDB Postgres AI Cloud Service Postgres databases. The service is not available in BYOA deployments. Also, as I understand it the service is only available in AWS and none of the other CSPs that the EDB Postgres AI Cloud Service runs on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, what do you think if I change the current heading from "Database versions" to "Source database versions". After that section, I can add a new section called "Target database versions", where I add the following statement:

Data Migration Service supports migrating to EDB Postgres AI Cloud Services. The target Postgres database cluster must meet the following requirements:

Other Cloud Services providers and Your Cloud Account deployments are currently not supported.

advocacy_docs/edb-postgres-ai/migration-etl/data-migration-service/getting_started/index.mdx Outdated Show resolved Hide resolved
advocacy_docs/edb-postgres-ai/migration-etl/data-migration-service/getting_started/index.mdx Outdated Show resolved Hide resolved
...ocs/edb-postgres-ai/migration-etl/data-migration-service/getting_started/create_database.mdx Outdated Show resolved Hide resolved
...docs/edb-postgres-ai/migration-etl/data-migration-service/getting_started/prepare_schema.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 11, 2024 07:51 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 11, 2024 09:23 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 12, 2024 07:20 Inactive
djw-m added 11 commits September 12, 2024 10:39
@djw-m
Revert "Implementing feedback from Matt p.1"
a79110b 
This reverts commit a23098f.
@djw-m
Revert "Merge pull request #6046 from EnterpriseDB/DMS/add_purl"
2e61b0e 
This reverts commit fd40474, reversing
changes made to 59f7846.
@djw-m
Revert "Merge pull request #6043 from EnterpriseDB/dms/migration_stop"
6b92276 
This reverts commit 59f7846, reversing
changes made to 72ee5d8.
@djw-m
Revert "Removed upgrade pages, as no upgrades are available now"
95b96f9 
This reverts commit b5add46.
@djw-m
Revert "Minor edits remaining sections"
14ef95a 
This reverts commit cebf22a.
@djw-m
Revert "Minor edits to getting started section"
0176837 
This reverts commit f83d62d.
@djw-m
Revert "Fixed step-by-step descriptions in index page for migration w…
c3c6a9d 
…orkflow"

This reverts commit 3ca9f1b.
@djw-m
Revert "Removed installation/removal steps as they are empty as discu…
541fd6d 
…ssed with Kyle"

This reverts commit 2afefcf.
@djw-m
Revert "Last pass of edits after testing"
779c291 
This reverts commit 3281abf.
@djw-m
Revert "Rebuild with test DMS content and fix right hand TOCs"
ea7fcfa 
This reverts commit 79def0b.

Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Misc fixups post reversion
cfe3234 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 12, 2024 10:19 Inactive
@github-actions github-actions bot temporarily deployed to pr-5935-poc-e10ai-frontpageexpansion September 12, 2024 10:55 Inactive
@djw-m
Fix (copiloted) links (bad copilot)
4dc95b2 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m djw-m merged commit 487a9b1 into develop Sep 17, 2024
3 checks passed
@djw-m djw-m deleted the poc/e10ai/frontpageexpansion branch September 17, 2024 09:22
@djw-m djw-m mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvasquezvargas gvasquezvargas gvasquezvargas left review comments

@mlewandowski-edb mlewandowski-edb mlewandowski-edb left review comments

@jpe442 jpe442 jpe442 approved these changes

Assignees

@djw-m djw-m

Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djw-m @jpe442 @mlewandowski-edb @gvasquezvargas @josh-heyer