Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGD re-edit group 5 #5806

Merged
merged 3 commits into from
Jul 3, 2024
Merged

PGD re-edit group 5 #5806

merged 3 commits into from
Jul 3, 2024

Conversation

ebgitelman
Copy link
Contributor

What Changed?

@gvasquezvargas gvasquezvargas force-pushed the docs/pgd_reedit_group5 branch from 7af936e to cc90585 Compare July 2, 2024 06:44
@gvasquezvargas gvasquezvargas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-5806--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-5806-docs-pgd_reedit_group5 July 2, 2024 06:53 Inactive
gvasquezvargas
gvasquezvargas reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two minor comments.

product_docs/docs/pgd/5/durability/limitations.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/5/durability/overview.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-5806-docs-pgd_reedit_group5 July 3, 2024 15:30 Inactive
@ebgitelman
Copy link
Contributor Author

@djw-m @gvasquezvargas @jpe442 Can someone approve this and/or let me know if you prefer Gaby's revision in the comments above?

@ebgitelman
Copy link
Contributor Author

@gvasquezvargas I think this is ready to approve.

gvasquezvargas
gvasquezvargas approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ebgitelman ebgitelman merged commit 193547f into develop Jul 3, 2024
2 checks passed
@ebgitelman ebgitelman deleted the docs/pgd_reedit_group5 branch July 3, 2024 17:55
@djw-m djw-m mentioned this pull request Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvasquezvargas gvasquezvargas gvasquezvargas approved these changes

@djw-m djw-m Awaiting requested review from djw-m

@jpe442 jpe442 Awaiting requested review from jpe442

@piano35-edb piano35-edb Awaiting requested review from piano35-edb

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ebgitelman @gvasquezvargas @djw-m