Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to style guide #5762

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Edits to style guide #5762

merged 3 commits into from
Jun 26, 2024

Conversation

ebgitelman
Copy link
Contributor

Added clarification on future tense, conditional tense, and contractions. Cleaned up the rest of the text to better adhere to our style guide.

Added clarification on future tense, conditional tense, and contractions. Cleaned up the rest of the text to better adhere to our style guide.

To create a table, use pipes (`|`) between columns and at least 3 dashes (`-`) separating the header cells from the body cells. A return denotes the start of the next row. The text within each column does not need to align in order to be rendered correctly, and you can inline Markdown or HTML.
To create a table, use pipes (`|`) between columns and at least 3 dashes (`-`) separating the header cells from the body cells. A return denotes the start of the next row. The text within each column doesn't need to align to be rendered correctly, and you can inline Markdown or HTML.

We don’t use outer pipes.
Copy link
Contributor Author

@ebgitelman ebgitelman Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djw-m Is this true?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few minor comments ;)

Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank youuuu!

Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw-m djw-m merged commit 6624943 into develop Jun 26, 2024
1 check passed
@djw-m djw-m deleted the docs/edits_to_style_guide branch June 26, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants