-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TDE on BigAnimal with Customer Managed Keys #5751
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvasquezvargas
added
the
deploy
Add this label to a PR and it will automatically be deployed to netlify
label
Jun 10, 2024
gvasquezvargas
requested review from
jpe442,
nidhibhammar and
piano35-edb
as code owners
June 10, 2024 16:34
gvasquezvargas
commented
Jun 12, 2024
gvasquezvargas
commented
Jun 12, 2024
product_docs/docs/biganimal/release/getting_started/creating_a_cluster/index.mdx
Show resolved
Hide resolved
gvasquezvargas
commented
Jun 12, 2024
product_docs/docs/biganimal/release/getting_started/creating_a_cluster/index.mdx
Outdated
Show resolved
Hide resolved
gvasquezvargas
commented
Jun 12, 2024
product_docs/docs/biganimal/release/overview/03_security/index.mdx
Outdated
Show resolved
Hide resolved
gvasquezvargas
commented
Jun 12, 2024
product_docs/docs/biganimal/release/overview/03_security/index.mdx
Outdated
Show resolved
Hide resolved
gvasquezvargas
commented
Jun 12, 2024
product_docs/docs/biganimal/release/overview/03_security/index.mdx
Outdated
Show resolved
Hide resolved
gvasquezvargas
commented
Jun 12, 2024
product_docs/docs/biganimal/release/administering_cluster/projects.mdx
Outdated
Show resolved
Hide resolved
GabriFedi97
requested changes
Jun 13, 2024
product_docs/docs/biganimal/release/overview/03_security/index.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/biganimal/release/using_cluster/managing_replicas.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/biganimal/release/using_cluster/05a_deleting_your_cluster.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/biganimal/release/getting_started/creating_a_cluster/index.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/biganimal/release/getting_started/creating_a_cluster/index.mdx
Outdated
Show resolved
Hide resolved
gvasquezvargas
force-pushed
the
BA/TDE-with-CMK
branch
from
June 17, 2024 08:28
bd4ab02
to
1319453
Compare
GabriFedi97
requested changes
Jun 17, 2024
product_docs/docs/biganimal/release/getting_started/creating_a_cluster/index.mdx
Outdated
Show resolved
Hide resolved
product_docs/docs/biganimal/release/getting_started/creating_a_cluster/index.mdx
Outdated
Show resolved
Hide resolved
nidhibhammar
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
GabriFedi97
approved these changes
Jun 18, 2024
gvasquezvargas
force-pushed
the
BA/TDE-with-CMK
branch
from
June 25, 2024 07:25
62f1687
to
1794a4e
Compare
gvasquezvargas
commented
Jun 25, 2024
Generalized AWS Principal statement to contain generic info. Co-authored-by: Gabriele Fedi <[email protected]>
More explicit statement around unsupported backing up/restoring use cases
gvasquezvargas
force-pushed
the
BA/TDE-with-CMK
branch
from
June 26, 2024 12:30
38e739e
to
62e2a97
Compare
I read the new TDE documentation and it looks good to me! Thank you! |
dbwagoner
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
https://enterprisedb.atlassian.net/browse/DOCS-724
Final UI changes are being made as we speak.