Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding default PGD commit_scopes for BigAnimal #5470

Merged
merged 10 commits into from
Apr 24, 2024
Merged

Adding default PGD commit_scopes for BigAnimal #5470

merged 10 commits into from
Apr 24, 2024

Conversation

jpe442
Copy link
Contributor

@jpe442 jpe442 commented Apr 3, 2024 •
edited
Loading

What Changed?

Added a page describing the PGD commit scope presets for PGD clusters on BA.

@jpe442 jpe442 added the deploy Add this label to a PR and it will automatically be deployed to netlify label Apr 3, 2024
@jpe442 jpe442 force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from a4f7916 to 4bf1d1b Compare April 3, 2024 20:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-5470--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 3, 2024 20:23 Inactive
@jpe442 jpe442 requested review from djw-m and aaronsonntag April 3, 2024 20:29
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 5, 2024 16:06 Inactive
@jpe442 jpe442 force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from 43256d0 to a2f6085 Compare April 8, 2024 14:05
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 8, 2024 14:19 Inactive
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 8, 2024 18:02 Inactive
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 9, 2024 21:49 Inactive
@jpe442 jpe442 force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from 75d390a to 1bb3345 Compare April 10, 2024 18:54
@jpe442 jpe442 marked this pull request as ready for review April 10, 2024 18:54
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 10, 2024 18:58 Inactive
djw-m
djw-m reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments left.

product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/using_cluster/pgd_defaults_ba.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 16, 2024 16:31 Inactive
@jpe442 jpe442 force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from 79cd5e6 to d142ff4 Compare April 16, 2024 18:54
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 16, 2024 19:22 Inactive
@jpe442 jpe442 force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from 489250c to db8e045 Compare April 17, 2024 20:55
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 17, 2024 20:59 Inactive
@jpe442 jpe442 force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from db8e045 to f05ef38 Compare April 19, 2024 18:06
@github-actions github-actions bot temporarily deployed to pr-5470-biganimal-release-overview-02_high_availability-docs-42a April 19, 2024 18:09 Inactive
@djw-m djw-m force-pushed the biganimal/release/overview/02_high_availability/DOCS-42a branch from f05ef38 to cfbd363 Compare April 23, 2024 16:00
djw-m
djw-m approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (have we had a BA tech review?)

@jpe442
Copy link
Contributor Author

jpe442 commented Apr 24, 2024

LGTM (have we had a BA tech review?)

Yes Aaron Sonntag checked it out and put in his suggestions. I also checked in #eng-pgd regarding the wording describing the rules.

@jpe442 jpe442 merged commit 5e6e296 into develop Apr 24, 2024
2 checks passed
@jpe442 jpe442 deleted the biganimal/release/overview/02_high_availability/DOCS-42a branch April 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw-m djw-m djw-m approved these changes

@aaronsonntag aaronsonntag Awaiting requested review from aaronsonntag

@nidhibhammar nidhibhammar Awaiting requested review from nidhibhammar

@piano35-edb piano35-edb Awaiting requested review from piano35-edb

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpe442 @djw-m