Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigAnimal - AWS Secrets Manager Integration #5465

Merged
merged 28 commits into from
May 21, 2024
Merged

BigAnimal - AWS Secrets Manager Integration #5465

merged 28 commits into from
May 21, 2024

Conversation

nidhibhammar
Copy link
Contributor

What Changed?

Addresses DOC-196

@nidhibhammar nidhibhammar added the deploy Add this label to a PR and it will automatically be deployed to netlify label Apr 2, 2024
@nidhibhammar nidhibhammar marked this pull request as draft April 2, 2024 07:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-5465--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 2, 2024 07:54 Inactive
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 4, 2024 10:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 5, 2024 05:46 Inactive
@nidhibhammar nidhibhammar requested a review from ebgitelman April 8, 2024 18:06
ebgitelman
ebgitelman reviewed Apr 8, 2024
View reviewed changes
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
nidhibhammar and others added 5 commits April 9, 2024 12:00
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
111144b 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
48a65d1 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
17a6595 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
19b790d 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
656b0c2 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 9, 2024 06:35 Inactive
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
f20c65d 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 9, 2024 06:38 Inactive
nidhibhammar and others added 6 commits April 9, 2024 14:02
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
83b03f4 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
96f6bda 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
02b0dcf 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
4e1ebc7 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
e3185e9 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
996fe37 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 9, 2024 08:37 Inactive
nidhibhammar and others added 2 commits April 9, 2024 14:09
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
b253351 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@nidhibhammar @ebgitelman
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
6b90587 
…secrets_manager_integration.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
aaronsonntag
aaronsonntag reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@aaronsonntag aaronsonntag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

posted a couple comments

product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
product_docs/docs/biganimal/release/administering_cluster/aws_secrets_manager_integration.mdx Outdated Show resolved Hide resolved
nidhibhammar and others added 2 commits April 11, 2024 17:07
@nidhibhammar @aaronsonntag
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
d74d520 
…secrets_manager_integration.mdx

Co-authored-by: aaronsonntag <[email protected]>
@nidhibhammar @aaronsonntag
Update product_docs/docs/biganimal/release/administering_cluster/aws_…
8d5376d 
…secrets_manager_integration.mdx

Co-authored-by: aaronsonntag <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 11, 2024 11:41 Inactive
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager April 18, 2024 06:37 Inactive
@github-actions github-actions bot temporarily deployed to pr-5465-content-docs-biganimal-secrets_manager May 16, 2024 11:45 Inactive
@nidhibhammar
Copy link
Contributor Author

@kwaarboncana, I made the edits as we discussed and updated the example according to your shared example. Please let me know if you need any more changes.

@amrita-suresh, Please review and let me know when to publish.

amrita-suresh
amrita-suresh approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@amrita-suresh amrita-suresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! I think we are ready to publish

@nidhibhammar nidhibhammar marked this pull request as ready for review May 17, 2024 08:23
@nidhibhammar nidhibhammar merged commit 442293b into develop May 21, 2024
2 checks passed
@nidhibhammar nidhibhammar deleted the content/docs/biganimal/secrets_manager branch May 21, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebgitelman ebgitelman ebgitelman left review comments

@aaronsonntag aaronsonntag aaronsonntag left review comments

@amrita-suresh amrita-suresh amrita-suresh approved these changes

@kwaarboncana kwaarboncana Awaiting requested review from kwaarboncana

@jpe442 jpe442 Awaiting requested review from jpe442

@piano35-edb piano35-edb Awaiting requested review from piano35-edb

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nidhibhammar @amrita-suresh @aaronsonntag @ebgitelman