Fixing indentation and versioning for PEM 8 and 9 #5379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvasquezvargas
added
the
deploy
gvasquezvargas
commented
Mar 12, 2024
| @@ -92,4 +92,4 @@ Where: | |||
| - `agent_name` specifies a descriptive name for the PEM agent. | |||
|
|
|||
| !!! Note | |||
| When configuring a shell/batch script run by a Windows agent that has PEM 7.11 or later version installed, set the `AllowBatchJobSteps` parameter to `True` in the `agent.cfg` file. The PEM agent doesn't execute any batch/shell script by default. | |||
| When configuring a shell/batch script run by a Windows agent that has PEM 8 or later version installed, set the `AllowBatchJobSteps` parameter to `True` in the `agent.cfg` file. The PEM agent doesn't execute any batch/shell script by default. | |||
There was a problem hiding this comment.
@sonotley since we don't support 7.x anymore, I bumped this to 8 as well.
Commenting here just to make sure this note is still relevant in 8 and 9 installations?
There was a problem hiding this comment.
I suggest we keep the note but remove the reference to the version, as it now applies to all supported versions.
sonotley
requested changes
Mar 12, 2024
| @@ -92,4 +92,4 @@ Where: | |||
| - `agent_name` specifies a descriptive name for the PEM agent. | |||
|
|
|||
| !!! Note | |||
| When configuring a shell/batch script run by a Windows agent that has PEM 7.11 or later version installed, set the `AllowBatchJobSteps` parameter to `True` in the `agent.cfg` file. The PEM agent doesn't execute any batch/shell script by default. | |||
| When configuring a shell/batch script run by a Windows agent that has PEM 8 or later version installed, set the `AllowBatchJobSteps` parameter to `True` in the `agent.cfg` file. The PEM agent doesn't execute any batch/shell script by default. | |||
There was a problem hiding this comment.
I suggest we keep the note but remove the reference to the version, as it now applies to all supported versions.
| @@ -91,4 +91,4 @@ Where: | |||
| - `agent_name` specifies a descriptive name for the PEM agent. | |||
|
|
|||
| !!! Note | |||
| When configuring a shell/batch script run by a Windows agent that has PEM 7.11 or later version installed, set the `AllowBatchJobSteps` parameter to `True` in the `agent.cfg` file. The PEM agent doesn't execute any batch/shell script by default. | |||
| When configuring a shell/batch script run by a Windows agent that has PEM 8 or later version installed, set the `AllowBatchJobSteps` parameter to `True` in the `agent.cfg` file. The PEM agent doesn't execute any batch/shell script by default. | |||
There was a problem hiding this comment.
updated both instances ✅
sonotley
approved these changes
Mar 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Fixing indentation and versioning issues flagged through GH issue by Simon.
#5374
https://enterprisedb.atlassian.net/browse/DOCS-199