Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PGD 4 Manual Install DOCS-122 #5333

Merged
merged 10 commits into from
Apr 30, 2024
Merged

PGD 4 Manual Install DOCS-122 #5333

merged 10 commits into from
Apr 30, 2024

Conversation

djw-m
Copy link
Contributor

@djw-m djw-m commented Mar 4, 2024

What Changed?

@djw-m djw-m self-assigned this Mar 4, 2024
@djw-m djw-m marked this pull request as draft March 4, 2024 12:23
@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Mar 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 4, 2024 •
edited
Loading

🚀 Deployed on https://deploy-preview-5333--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus March 4, 2024 12:55 Inactive
@djw-m djw-m changed the title First commit with initial changes for PGD 4 PGD 4 Manual Install DOCS-112 Mar 4, 2024
@djw-m djw-m changed the title PGD 4 Manual Install DOCS-112 PGD 4 Manual Install DOCS-122 Mar 4, 2024
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus March 4, 2024 15:07 Inactive
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus March 5, 2024 10:52 Inactive
ibarwick
ibarwick previously requested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ibarwick ibarwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some minor, mostly pedantic comments from a first read-through, and noted some places where the links should go to the 4.x reference docs, rather than current.

product_docs/docs/pgd/4/admin-manual/installing/index.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/05-creating-cluster.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/05-creating-cluster.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/05-creating-cluster.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/05-creating-cluster.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/05-creating-cluster.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/06-check-cluster.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/07-using-pgd-cli.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/07-using-pgd-cli.mdx Outdated Show resolved Hide resolved
product_docs/docs/pgd/4/admin-manual/installing/07-using-pgd-cli.mdx Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus March 27, 2024 09:19 Inactive
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 2, 2024 12:24 Inactive
@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from e708dcb to 57ca526 Compare April 4, 2024 11:17
@djw-m djw-m marked this pull request as ready for review April 4, 2024 11:17
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 4, 2024 11:41 Inactive
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 4, 2024 19:01 Inactive
@ebgitelman
Copy link
Contributor

I took as light a touch as possible with this. I did eliminate first person plural, especially as topics tended to switch between first and second person. But I was careful with how I did it.

@djw-m djw-m requested a review from ibarwick April 10, 2024 15:27
@djw-m djw-m dismissed ibarwick’s stale review April 10, 2024 15:30

It's a meta comment on the other review comments

@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from c76a732 to cff7bd6 Compare April 10, 2024 15:30
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 10, 2024 15:47 Inactive
@djw-m djw-m requested a review from MattWalliEDB April 17, 2024 17:00
@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from cff7bd6 to 3581c71 Compare April 17, 2024 17:42
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 17, 2024 18:05 Inactive
@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from 3581c71 to 3764402 Compare April 18, 2024 05:29
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 18, 2024 05:32 Inactive
MattWalliEDB
MattWalliEDB approved these changes Apr 23, 2024
View reviewed changes
Copy link

@MattWalliEDB MattWalliEDB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments here: https://enterprisedb.atlassian.net/browse/DOCS-122?focusedCommentId=582408

@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 24, 2024 09:42 Inactive
@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from a070d06 to a8a40c3 Compare April 24, 2024 09:43
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 24, 2024 09:53 Inactive
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 24, 2024 11:12 Inactive
@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from 808c81f to c08d64a Compare April 24, 2024 11:49
@github-actions github-actions bot temporarily deployed to pr-5333-docs-pgd-new-docs-122-request-for-docs-document-initial-clus April 24, 2024 11:52 Inactive
djw-m and others added 10 commits April 30, 2024 09:16
@djw-m
First commit with initial changes for PGD 4
14e74c4 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Updates to the cli docs removing features
3d02ff0 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Remove proxies from this version
79cc964 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Remove proxies from top page
808a57a 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Apply suggestions from review
7b95cd2
@djw-m
Fixes from review
854e075 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@ebgitelman @djw-m
Editorial review of manual install
b65c50e
@djw-m
Fix two packages to one package
febb12d 
(Removal of proxy section)
@djw-m
Positioned content, made requested changes
256f834 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Fix tense in product_docs/docs/pgd/4/deployments/index.mdx
a06d924
@djw-m djw-m force-pushed the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch from c08d64a to a06d924 Compare April 30, 2024 08:16
@djw-m djw-m merged commit 06cb37e into develop Apr 30, 2024
1 check passed
@djw-m djw-m deleted the docs/pgd/new/DOCS-122-request-for-docs-document-initial-clus branch April 30, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebgitelman ebgitelman ebgitelman left review comments

@MattWalliEDB MattWalliEDB MattWalliEDB approved these changes

@ibarwick ibarwick Awaiting requested review from ibarwick

@jpe442 jpe442 Awaiting requested review from jpe442

@piano35-edb piano35-edb Awaiting requested review from piano35-edb

Assignees

@djw-m djw-m

Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djw-m @ebgitelman @ibarwick @MattWalliEDB