Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document PostGIS extension in BigAnimal #4902

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

josh-heyer
Copy link
Contributor

What Changed?

Continues on from #4889 which was merged early

Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be correct. PostGIS is enabled in the Additional Settings tab, not the DB Configuration tab. This may or may not be correct for some arbitrary UI change coming.

@ebgitelman
Copy link
Contributor

This doesn't seem to be correct. PostGIS is enabled in the Additional Settings tab, not the DB Configuration tab. This may or may not be correct for some arbitrary UI change coming.

@amrita-suresh Can you let me know if DJ's comment is correct or if the doc is correct as revised? Thank you!

@amrita-suresh
Copy link
Contributor

@ebgitelman DJ's comment is correct, it should be the Additional Settings tab. My bad!

@@ -69,7 +70,7 @@ EDB extensions:

## Installing extensions

Use the [`CREATE EXTENSION`](https://www.postgresql.org/docs/current/sql-createextension.html) command to install extensions, except for the EDB Postgres Tuner (pg_tuner) extension. You enable edb_pg_tuner on the **DB Configuration** tab of the Create or Edit Cluster page of the BigAnimal portal.
Use the [`CREATE EXTENSION`](https://www.postgresql.org/docs/current/sql-createextension.html) command to install most extensions. You must enable certain extensions, including the EDB Postgres Tuner (pg_tuner) extension and PostGIS on the **DB Configuration** tab of the Create or Edit Cluster page of the BigAnimal portal.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the [`CREATE EXTENSION`](https://www.postgresql.org/docs/current/sql-createextension.html) command to install most extensions. You must enable certain extensions, including the EDB Postgres Tuner (pg_tuner) extension and PostGIS on the **DB Configuration** tab of the Create or Edit Cluster page of the BigAnimal portal.
Use the [`CREATE EXTENSION`](https://www.postgresql.org/docs/current/sql-createextension.html) command to install most extensions. You must enable certain extensions, including the EDB Postgres Tuner (pg_tuner) extension and PostGIS. Enable pg_tuner on the **DB Configuration** tab of the Create or Edit Cluster page of the BigAnimal portal. Enable PostGIS on the **Additional Settings** tab.

@amrita-suresh @djw-m All good now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't seem to be a simple Enable pg_tuner on DB Configuration:

Screenshot 2023-11-14 at 17 41 20

I suggest more guidance on that issue. Apart from that, it's fine.

@josh-heyer josh-heyer force-pushed the docs/biganimal/postgis_for_big_animal_UPM-24096 branch from 6fb3279 to 3885aed Compare April 10, 2024 14:50
@josh-heyer
Copy link
Contributor Author

@amrita-suresh can this be merged?

@amrita-suresh
Copy link
Contributor

@josh-heyer yes!

@josh-heyer josh-heyer force-pushed the docs/biganimal/postgis_for_big_animal_UPM-24096 branch from 3885aed to c0f1553 Compare April 23, 2024 18:47
@josh-heyer josh-heyer merged commit 00c86ac into develop Apr 23, 2024
1 check passed
@josh-heyer josh-heyer deleted the docs/biganimal/postgis_for_big_animal_UPM-24096 branch April 23, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants