Move scrolling to proper callback, avoid animation #4895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-heyer
added
the
deploy
github-actions
bot
temporarily deployed
to
pr-4895-bugfix-josh-squash-weird-scrolling-on-fragment-link
|
Seems to work here, much snappier browsing the reference too. |
github-actions
bot
temporarily deployed
to
pr-4895-bugfix-josh-squash-weird-scrolling-on-fragment-link
Then rely on default behavior.
josh-heyer
force-pushed
the
bugfix/josh/squash-weird-scrolling-on-fragment-link
branch
from
f5e0f27 to
f93fc46
Compare
josh-heyer
deleted the
bugfix/josh/squash-weird-scrolling-on-fragment-link
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Appears there were at least three different places where scrolling would potentially be forced on navigation:
...not to mention the default browser behavior, which would (should?) also work on page load.
Generally, this didn't seem to cause issues, but occasionally an odd behavior would emerge: navigating to a section within a page would jump the scroll position much further down. Oddly, this seems to disappear if the #3 logic is eliminated in favor of a selective override of #2.