update dependencies: September 2023 #4860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-heyer
force-pushed
the
chore/update-dependencies-9-2023
branch
from
0d319a5 to
2bc4913
Compare
josh-heyer
added
the
deploy
josh-heyer
force-pushed
the
chore/update-dependencies-9-2023
branch
from
2bc4913 to
c8e853b
Compare
github-actions
bot
temporarily deployed
to
pr-4860-chore-update-dependencies-9-2023
|
The search box's category -> All Products etc. -> has flipped from white on blue to black on blue. (I'm on a light mode system setting here) flipping mode doesn't change colour (as per current production) - seems to have just been flipped. |
Little odd - I assume that it's the mismatch between the algolia db and the preview but wanted to flag that. |
djw-m
previously approved these changes
Sep 28, 2023
|
Took me way too long to figure out the color thing. Turns out Bootstrap 5 picks a foreground color based on what will provide the best contrast for the background... And our blue has crappy contrast with white:
Options:
|
|
I would likely go for a darker shade of blue and the black/blue contrast is
more painful.
…On Fri, Sep 29, 2023 at 6:05 AM Josh Heyer ***@***.***> wrote:
Took me way too long to figure out the color thing. Turns out Boostrap 5
picks a foreground color based on what will provide the best contrast for
the background... And our blue has crappy contrast with white:
[image: image]
<https://user-images.githubusercontent.com/63653723/271476174-ef186339-f81d-4654-868d-c10ad842905c.png>
Options:
1. Leave text black (and adjust styles on other buttons to match)
2. Use a slightly darker shade of blue (e.g. #3e6e8e)
—
Reply to this email directly, view it on GitHub
<#4860 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6E5CB6CK3L3RZULZDN3BYTX4ZJKZANCNFSM6AAAAAA5JZHWN4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
github-actions
bot
temporarily deployed
to
pr-4860-chore-update-dependencies-9-2023
upgrade icons upgrade bootstrap upgrade husky
- switch to instantsearch 7 API - address breaking changes in boostrap 5 - fix: incorrect path parsing for 404 page search - fix: race condition in global search bar initialization - fix: product filter dropdown appears behind search results in global search - fix: honor system dark mode preference when no local preference is set Also replaced pretty-quick with lint-staged, as new prettier is unsupported by the former
(black text on blue for primary for now to hit contrast needs) Also re-enable underlines for hover on links. At some point this needs a thorough review for accessibility
josh-heyer
force-pushed
the
chore/update-dependencies-9-2023
branch
from
814c26a to
6135977
Compare
|
Altered rules to achieve consistency for now; added #4868 to track future work on better contrast. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed?
Notable updates:
The last two required substantial revisions to support the major version updates. As part of these, I've fixed a few related issues:
Also replaced pretty-quick with lint-staged, as new prettier is unsupported by the former. May not have the configuration quite right for this.