Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigAnimal: Azure-BAH private networking #4858

Merged
merged 8 commits into from
Oct 5, 2023

Conversation

ccestes
Copy link
Contributor

@ccestes ccestes commented Sep 27, 2023

What Changed?

Implementing Azure-BAH private networking updates:

@ccestes ccestes added the deploy Add this label to a PR and it will automatically be deployed to netlify label Sep 27, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

@github-actions github-actions bot temporarily deployed to pr-4858-docs-biganimal-azure-bah-private-networking September 27, 2023 15:05 Inactive
Copy link
Contributor

@valeriodelsarto valeriodelsarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding a little suggestion, rest of the content LGTM!

@github-actions github-actions bot temporarily deployed to pr-4858-docs-biganimal-azure-bah-private-networking September 28, 2023 13:03 Inactive
@github-actions github-actions bot temporarily deployed to pr-4858-docs-biganimal-azure-bah-private-networking September 29, 2023 14:12 Inactive
@ccestes ccestes force-pushed the docs/biganimal/azure-bah-private-networking branch from 07ddd54 to c7b29cb Compare September 29, 2023 14:14
@github-actions github-actions bot temporarily deployed to pr-4858-docs-biganimal-azure-bah-private-networking September 29, 2023 14:18 Inactive
Copy link
Contributor

@valeriodelsarto valeriodelsarto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a couple of comments, the rest LGTM!

changed section title

changes to example
@ccestes ccestes force-pushed the docs/biganimal/azure-bah-private-networking branch from c7b29cb to 9ba5ce0 Compare September 29, 2023 15:33
@github-actions github-actions bot temporarily deployed to pr-4858-docs-biganimal-azure-bah-private-networking September 29, 2023 15:36 Inactive
Copy link
Contributor

@ebgitelman ebgitelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small changes.

ccestes and others added 2 commits October 3, 2023 10:12
…g_your_cluster/01_connecting_from_azure/index.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
…g_and_logging/monitoring_from_azure/index.mdx

Co-authored-by: Betsy Gitelman <[email protected]>
@github-actions github-actions bot temporarily deployed to pr-4858-docs-biganimal-azure-bah-private-networking October 3, 2023 14:15 Inactive
@ccestes ccestes merged commit 481c62e into develop Oct 5, 2023
1 check passed
@ccestes ccestes deleted the docs/biganimal/azure-bah-private-networking branch October 5, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants