Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New style for release notes adding full title and date #4843

Merged
merged 1 commit into from
Sep 26, 2023
Merged

New style for release notes adding full title and date #4843

merged 1 commit into from
Sep 26, 2023

Conversation

dwicinas
Copy link
Contributor

Added full title and release date for most recent version of all products with release notes in the product_docs/docs folder. Some products in that folder do not have release notes, and some products reside in a pg_extensions folder, for which I don't seem to have access.

@dwicinas dwicinas added the deploy Add this label to a PR and it will automatically be deployed to netlify label Sep 25, 2023
@dwicinas dwicinas requested a review from djw-m as a code owner September 25, 2023 15:55
@github-actions
Copy link
Contributor

🚀 Deployed on https://deploy-preview-4843--edb-docs-staging.netlify.app

djw-m
djw-m approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - would have liked one or two older versions also dated but we can move forward from this. Did you check that the change on CNPG won't get overwritten on import or are the release notes still manually created?

nidhibhammar
nidhibhammar approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@nidhibhammar nidhibhammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We can proceed with this and do the same task for two older versions for all the products in separate PR.

@nidhibhammar nidhibhammar merged commit 711855c into develop Sep 26, 2023
1 check passed
@nidhibhammar nidhibhammar deleted the docs/release-notes/dates-titles branch September 26, 2023 09:13
@nidhibhammar nidhibhammar mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw-m djw-m djw-m approved these changes

@nidhibhammar nidhibhammar nidhibhammar approved these changes

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dwicinas @nidhibhammar @djw-m