Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New durability section - in development #4677

Merged
merged 49 commits into from
Dec 11, 2023
Merged

New durability section - in development #4677

merged 49 commits into from
Dec 11, 2023

Conversation

djw-m
Copy link
Contributor

@djw-m djw-m commented Aug 23, 2023 •
edited
Loading

What Changed?

Everything - moved the sections now, indexised and reference work being done too in this pass. Need to resolve Eager as a thing.

Work for https://enterprisedb.atlassian.net/browse/BDR-4237

@djw-m djw-m self-assigned this Aug 23, 2023
@djw-m djw-m marked this pull request as draft August 23, 2023 14:55
@djw-m djw-m added the deploy Add this label to a PR and it will automatically be deployed to netlify label Aug 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 23, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-4677--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 August 23, 2023 15:31 Inactive
This was referenced Aug 24, 2023
Closed
Closed
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 August 29, 2023 10:00 Inactive
@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from df2c4cd to 214c9fd Compare August 30, 2023 13:48
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 August 30, 2023 14:22 Inactive
@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from 214c9fd to e02d293 Compare August 31, 2023 16:04
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 August 31, 2023 16:11 Inactive
@mwanner mwanner self-requested a review September 7, 2023 13:50
@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from aa5fc5f to 8f15782 Compare September 8, 2023 08:17
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 September 8, 2023 08:22 Inactive
LenzGr
LenzGr reviewed Sep 8, 2023
View reviewed changes
product_docs/docs/pgd/5/durability/limitations.mdx Outdated
Comment on lines 20 to 23
[Legacy synchronous replication](legacy-sync) uses a mechanism for transaction
confirmation different from Group Commit. The two aren't compatible, and you
must not use them together. Therefore, whenever you Group Commit transactions,
make sure none of the PGD nodes are configured in `synchronous_standby_names`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a question for @PJMODOS or @mwanner - could we technically prevent this by raising an error if the user enables legacy synchronous replication?

@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from 8f15782 to d6d16e4 Compare September 19, 2023 14:38
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 September 19, 2023 14:53 Inactive
@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from c1b1f11 to 36767e7 Compare October 9, 2023 10:23
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 October 9, 2023 10:47 Inactive
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 October 10, 2023 07:47 Inactive
@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from be94223 to 00a6edf Compare October 23, 2023 08:29
@github-actions github-actions bot temporarily deployed to pr-4677-doc-fix-durabilityref3 October 23, 2023 08:50 Inactive
djw-m and others added 23 commits December 8, 2023 09:52
@djw-m
Actual commit (as missed file previously)
f2c6cb0 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Update product_docs/docs/pgd/5/durability/index.mdx
6c1c6d0 
Co-authored-by: Lenz Grimmer <[email protected]>
@djw-m
Update product_docs/docs/pgd/5/durability/index.mdx
c78bdd1 
Co-authored-by: Lenz Grimmer <[email protected]>
@djw-m
Review changes
39ea3c9 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Remove terms from overview, update reference
1dfeb39 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Update product_docs/docs/pgd/5/durability/lag-control.mdx
d503952 
Co-authored-by: Lenz Grimmer <[email protected]>
@djw-m
WIP Commit
b0e8edc 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
WIP Commit
7a3ce6d 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Added commit scope kinds
2ccccd8 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Update index for rules
329cffa 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Review edits
9b79c30 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Review edits cont.
50ae642 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Shorter version focussing on GC
07052f4 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Format and typo fix
7a54ea7 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Add deepToC
9e685fd 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
wrapped sync commit wordage - verification needed
168ce4e 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Clear end of doc
e434a67 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Fix reference commit scope entry
f91d961 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Link fixes
add4876 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Review Edits
56810c3 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
GH review comments resolved
f3e17cf 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Fixes for review comments from pjmodos
7f5a3ae 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m
Edits to comparing
3ab277a 
Signed-off-by: Dj Walker-Morgan <[email protected]>
@djw-m djw-m force-pushed the doc/fix/durabilityref3 branch from 8290b12 to 3ab277a Compare December 8, 2023 09:52
@djw-m djw-m requested review from PJMODOS and Metaluim December 11, 2023 09:57
@djw-m djw-m merged commit 98b365e into develop Dec 11, 2023
2 checks passed
@djw-m djw-m deleted the doc/fix/durabilityref3 branch December 11, 2023 09:58
@djw-m djw-m mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwanner mwanner Awaiting requested review from mwanner

@LenzGr LenzGr Awaiting requested review from LenzGr

@PJMODOS PJMODOS Awaiting requested review from PJMODOS

@Metaluim Metaluim Awaiting requested review from Metaluim

Assignees

@djw-m djw-m

Labels
deploy Add this label to a PR and it will automatically be deployed to netlify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djw-m @LenzGr @Metaluim @PJMODOS