Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EPAS 15 - AWS_EPAS_AMI doc #3884

Merged
merged 15 commits into from
Apr 23, 2024
Merged

EPAS 15 - AWS_EPAS_AMI doc #3884

merged 15 commits into from
Apr 23, 2024

Conversation

nidhibhammar
Copy link
Contributor

No description provided.

@nidhibhammar nidhibhammar added the deploy Add this label to a PR and it will automatically be deployed to netlify label Apr 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2023 •
edited
Loading

🚀 Deployed on https://deploy-preview-3884--edb-docs-staging.netlify.app

@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 4, 2023 09:48 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 5, 2023 12:26 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 5, 2023 20:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 6, 2023 05:59 Inactive
@nidhibhammar nidhibhammar requested a review from tusharahuja April 6, 2023 06:19
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 6, 2023 10:40 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 10, 2023 09:28 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 11, 2023 06:09 Inactive
@drothery-edb drothery-edb force-pushed the content/docs/epas/15/aws_epas branch from a870cd2 to 698b1fd Compare April 27, 2023 14:12
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 27, 2023 15:04 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 27, 2023 16:23 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas April 27, 2023 17:43 Inactive
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas May 2, 2023 09:58 Inactive
@josh-heyer josh-heyer added the waiting-on This is blocked on someone external: an upstream repo, something assigned in Jira, etc. label Aug 23, 2023
@jkitchens32
Copy link
Contributor

Commented in the Docs channel but wanted to leave a comment here as more than one suggested change may need to be made.

I have gone through the purchasing process end-to-end as a customer would and saw a few differences that will need to be changed in the doc.

The "Application and OS Images (Amazon Machine Image)" bullet under Creating an instance does not apply for a customer. It does not appear in the My AMIs tab. It can either be deployed from the Manage Subscriptions page in your AWS account or you can search "EDB" in the AWS Marketplace AMIs search bar to find it after you have purchased. So this would need to be re-worded to better fit how a non-EDB customer would deploy. The way we have it worded benefits someone who is internal to EDB. I can discuss more with anyone as needed.

@josh-heyer josh-heyer force-pushed the content/docs/epas/15/aws_epas branch from b0b446b to 5e9aa9f Compare September 12, 2023 20:18
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas September 12, 2023 20:32 Inactive
@nidhibhammar nidhibhammar force-pushed the content/docs/epas/15/aws_epas branch from 5e9aa9f to 4a59b78 Compare September 21, 2023 11:57
@github-actions github-actions bot temporarily deployed to pr-3884-content-docs-epas-15-aws_epas September 21, 2023 12:01 Inactive
@nidhibhammar
Copy link
Contributor Author

@dougcalobrisi, I have updated the content according to the screenshots provided. Please let me know if you need any more changes.

@djw-m djw-m requested review from tusharahuja and dougcalobrisi and removed request for tusharahuja and dougcalobrisi October 11, 2023 15:31
@nidhibhammar
Copy link
Contributor Author

@dougcalobrisi, do we have any update on this? When is this going out?

tusharahuja
tusharahuja approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@tusharahuja tusharahuja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@josh-heyer
Copy link
Contributor

@nidhibhammar what's the status on this PR?

dougcalobrisi
dougcalobrisi approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@dougcalobrisi dougcalobrisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on behalf of Kennedy Grimes

gvasquezvargas
gvasquezvargas approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@gvasquezvargas gvasquezvargas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nidhibhammar nidhibhammar merged commit 498dbf9 into develop Apr 23, 2024
1 check passed
@nidhibhammar nidhibhammar deleted the content/docs/epas/15/aws_epas branch April 23, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebgitelman ebgitelman ebgitelman left review comments

@drothery-edb drothery-edb drothery-edb left review comments

@gvasquezvargas gvasquezvargas gvasquezvargas approved these changes

@tusharahuja tusharahuja tusharahuja approved these changes

@dougcalobrisi dougcalobrisi dougcalobrisi approved these changes

Assignees
No one assigned
Labels
deploy Add this label to a PR and it will automatically be deployed to netlify upcoming-release waiting-on This is blocked on someone external: an upstream repo, something assigned in Jira, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@nidhibhammar @jkitchens32 @josh-heyer @dougcalobrisi @tusharahuja @drothery-edb @ebgitelman @gvasquezvargas @djw-m