Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add form.onChange #819

Merged
merged 4 commits into from
Sep 9, 2024
Merged

fix: add form.onChange #819

merged 4 commits into from
Sep 9, 2024

Conversation

sagardspeed2
Copy link
Contributor

@sagardspeed2 sagardspeed2 commented Sep 4, 2024

Describe your changes

added form onChange support

Screenshots [Optional]

Issue ticket number and link

Closes #812

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 3b28cd4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ensembleui/react-runtime Patch
@ensembleui/react-kitchen-sink Patch
@ensembleui/react-preview Patch
@ensembleui/react-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 4, 2024

Visit the preview URL for this PR (updated for commit 3b28cd4):

https://react-kitchen-sink-dev--pr819-812-form-onchange-1alrdgg4.web.app

(expires Mon, 16 Sep 2024 10:05:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

Copy link
Contributor

@anserwaseem anserwaseem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add example in kitchen sink as well

packages/runtime/src/widgets/Form/Form.tsx Outdated Show resolved Hide resolved
packages/runtime/src/widgets/Form/Form.tsx Outdated Show resolved Hide resolved
Update Form.tsx

Update Form.tsx
@sagardspeed2
Copy link
Contributor Author

@anserwaseem can you please check this ?

@sagardspeed2 sagardspeed2 merged commit f528819 into main Sep 9, 2024
3 checks passed
@sagardspeed2 sagardspeed2 deleted the 812-form-onChange branch September 9, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Form.onChange support
2 participants