Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor useExecuteCode to leverage atomCallback #814

Merged
merged 9 commits into from
Sep 24, 2024
Merged

Conversation

evshi
Copy link
Contributor

@evshi evshi commented Sep 1, 2024

Describe your changes

Refactors useExecuteCode dependencies to be fetched at execution instead of re-render, which should greatly improve performance. This required refactoring a bunch of dependencies into framework project and needs to be cleaned up further.

Screenshots [Optional]

Issue ticket number and link

Closes #

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests
  • I have added a changeset pnpm changeset add
  • I have added example usage in the kitchen sink app

Copy link

changeset-bot bot commented Sep 1, 2024

🦋 Changeset detected

Latest commit: aa267a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ensembleui/react-framework Patch
@ensembleui/react-kitchen-sink Patch
@ensembleui/react-runtime Patch
@ensembleui/react-preview Patch
@ensembleui/react-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 1, 2024

Visit the preview URL for this PR (updated for commit aa267a2):

https://react-kitchen-sink-dev--pr814-evshi-execute-code-ywyrz8ip.web.app

(expires Tue, 01 Oct 2024 22:23:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9

@evshi evshi marked this pull request as ready for review September 24, 2024 22:19
@evshi evshi merged commit b42978c into main Sep 24, 2024
3 checks passed
@evshi evshi deleted the evshi/execute-code branch September 24, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants