-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added support for custom fonts in ensemble studio #803
Conversation
🦋 Changeset detectedLatest commit: aa866a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Visit the preview URL for this PR (updated for commit aa866a4): https://react-kitchen-sink-dev--pr803-762-support-custom-f-cfsxmazw.web.app (expires Mon, 07 Oct 2024 05:08:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6267897ade2ba783b6db70a53a60fc3946d625e9 |
@evshi this PR is still not ready for review, I am still working on it |
@sagardspeed2 @evshi please see latest EDL example here: |
@sagardspeed2 is this ready to be merged? |
@evshi we need to run this in production first to clear the cors issue and I don't have the production firebase access |
@sagardspeed2 why do we need to run that command? @justEhmadSaeed is this something you can help with? |
@evshi we are trying to fetch the font files from the firebase and there is cors added for the origin. so when I tested it was giving cors error while fetching the font files from the firebase. so I used this command for dev firebase storage, and it works. |
@sagardspeed2 i don't understand why you need to set cors for fonts when it's already being fetched by the prod app. if you want to fetch the prod data on the local, then it's disabled intentionally. |
Describe your changes
Added support for custom fonts in ensemble studio
Screenshots [Optional]
uploaded font
added classname (
topHeader
) in screenadded style (
fontFamily
intopHeader
class) to class in themeoutput
Issue ticket number and link
Closes #762
Checklist before requesting a review
pnpm changeset add