Add support for "createBillingAgreement" #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdugan14
commented
Nov 22, 2022
| @@ -293,7 +299,7 @@ export type ShippingPreference = | |||
|
|
|||
| export type PaypalLandingPage = "LOGIN" | "BILLING"; | |||
|
|
|||
| export type OrderIntent = "CAPTURE" | "AUTHORIZE" | "subscription"; | |||
| export type OrderIntent = "CAPTURE" | "AUTHORIZE" | "subscription" | "tokenize"; | |||
There was a problem hiding this comment.
We use intent: "tokenize" with createBillingAgreement - here's paypal's docs
I didn't add any validation in this PR - the PayPal SDK will complain if we don't pass intent=tokenize and vault=true with createBillingAgreement, though
Enngage
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for "createBillingAgreement", for creating a Billing Agreement - a legacy PayPal flow that creates an agreement for recurring payments for goods or services (docs)
This callback is supported in paypal-js
This is an alternative use for the button - the
createBillingAgreementcallback is called on button click, instead of one of thecreateOrdercallbacks.Happy to add more details if needed :)