-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with potion condition #484
Open
Alexz1008
wants to merge
284
commits into
Eniripsa96:premium
Choose a base branch
from
Alexz1008:premium
base: premium
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed a bug where the bar would overwrite items in the inventory. This was because com.sucy.skill.api.player.countOpenSlots would count equipment slots and offhand as an empty slot. As such, if your bar was size 5 and you had no armor or offhand item but a full inventory, the bar would replace whatever was there. I fixed it with a hard-coded number for now but change it as you wish. |
Added toggle for Skill Bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, I changed more things than I wanted to, the SQLIO.java and CmdBackup.java don't have to be pulled.
To reproduce the issue:
Essentially, the problem is that when the player doesn't have the potion, line 72 gives a null pointer exception, leading to Line 59 to catch the exception. I don't actually know what the catch is for otherwise so maybe I broke some logic, but at least in my simple case it works with this fix.